Closed TomNUSDS closed 2 months ago
For discussion. Some of these bulk edits will probably need to be made to the larger api draft, too?
For optional fields, simplify declarations like this:
type: - integer - 'null'
was simplified to:
type: integer
Because these fields are not required:, the null is implied. It was generating warnings from one of the tools and is easier to read.
required:
Field names that were spelled exactly like model declaration names generated bad python. e.g. LivingSituation needed different names:
LivingSituation
LivingSituation: type: integer oneOf: - $ref: '#/components/schemas/LivingSituation'
One solution is to change the case from PascalCase to camelCase:
livingSituation: type: integer oneOf: - $ref: '#/components/schemas/LivingSituation'
But we could rename the schema model to LivingSituationType
LivingSituationType
HOPWAMedAssistedLivingFac
HOPWAMedAssistedLivingFacNum
For discussion. Some of these bulk edits will probably need to be made to the larger api draft, too?
For optional fields, simplify declarations like this:
was simplified to:
Because these fields are not
required:, the null is implied. It was generating warnings from one of the tools and is easier to read.Field names that were spelled exactly like model declaration names generated bad python. e.g.
LivingSituationneeded different names:One solution is to change the case from PascalCase to camelCase:
But we could rename the schema model to
LivingSituationTypeHOPWAMedAssistedLivingFacwas an exception to changing to camelCase because it starts with a long acronym. The schema model was renamed toHOPWAMedAssistedLivingFacNum