search

HUJI-Deep / simnets-tf

SimNets implementation in TensorFlow
MIT License
7 stars 3 forks source link

Padding API conventions #14

Closed orsharir closed 7 years ago

orsharir commented 7 years ago

Notice that in Tensorflow the padding api is specified in uppercase, i.e. 'SAME' and 'VALID', while in Keras it is in lowercase, i.e. 'same' and 'valid'. Our API should adhere to this convention. You could probably use this Keras's method to handle this change (or simply write your own).

elhanan7 commented 7 years ago

Actually the current padding argument could be 'SAME', 'VALID' or a list with integer values to specify the actual paddings, is this okay @orsharir ? (it's orthogonal of course to the upper/lower case issue)

orsharir commented 7 years ago

Yes, that's the correct behavior we've talked about. The upper/lower case issue is separate from that. If it's now fixed, you can close this issue.