HULKs / hulk

All your base are belong to us!
https://hulks.de/hulk
GNU General Public License v3.0
49 stars 49 forks source link

Communicatino server freewheels when setup node fails #1046

Open knoellle opened 1 month ago

knoellle commented 1 month ago

If a setup node panics or returns an error result, the output provider for that cycler in communication goes into an infinite loop. The issue is here where the result is ignored. wait_for_change returns an Err(NoSender) immediately if the sender has been dropped.

@schmidma does your rewrite handle this correctly?

schmidma commented 1 month ago

No, it currently does not. Good catch. I'll consider that