HULKs / hulk

All your base are belong to us!
https://hulks.de/hulk
GNU General Public License v3.0
61 stars 50 forks source link

Time to reach always has a value #1325

Open Narcha opened 3 months ago

Narcha commented 3 months ago

It seems like fallen robots often calculate a short TTRKP and thus claim striker. Investigate.

Examples:

MaikRe commented 3 months ago

Because of the inputs needed for time_to_reach_kick_position it runs after all of behavior and hands it's values to the cyclerstate in order for them to be used in the next cycle. As tracked in #402, this cycler state does not support options. Therefor the time to reach is always Duration::MAX rather than None, and because Lua in the behavior simulator cannot handle duration max it is reduced to 30 minutes. TLDR We cant have a time to reach of None meaning if everyone is looser everyone claims striker for at least one cycle

knoellle commented 3 months ago

CyclerState can contain an option, but it's impossible to set it to Some(..), this is a framework/code-gen bug