Deny False Positives in Visual Referee Detection

HULKs / hulk

All your base are belong to us!

https://hulks.de/hulk

GNU General Public License v3.0

49 stars 49 forks source link

Deny False Positives in Visual Referee Detection #999

Closed oleflb closed 2 months ago

oleflb commented 5 months ago

[ ] use horizon check
[ ] use height check
[x] use keypoint confidence
~maybe check "redness" at hand keypoints (remember the referee is wearing gloves)~

MaikRe commented 3 months ago

Although not relevant for this RoboCup, I would find it troubling if checking for redness was the solution to this as the red gloves are to be removed next robocup

schmidma commented 2 months ago

Is this fully resolved since #1094 was merged?

knoellle commented 2 months ago

AFAIK not, or at least not as proposed. The PR only uses confidences and relative keypoint positions for filtering. If I understand the original issue text correctly, the idea was to use the referee height as well to differentiate it from robots. Not quite sure what is meant by the horizon check.

However, if the detection now works reliably enough already, we could still close the issue. Keep in mind that we also have the voting and the sacrificial nao.

@ThagonDuarte?

oleflb commented 2 months ago

I also vote for closing, what do you think @ThagonDuarte?

ThagonDuarte commented 2 months ago

Yes, I agree.