Closed chambm closed 8 months ago
Maybe I should move this to the CV repository?
I think it is okay here, we can address it here, but I don't really understand how you want to solve this. Can you maybe add a little more info with a proposed solution?
Also, there's no PSI-MS call this week due to travel, but I'm hoping we can resolve this next Friday. Might you be able to join the call next Friday to help clarify a proposed solution?
The proposed solutions are simple: for these terms, either replace "ion selection attribute" with "scan attribute" or add "scan attribute" to the list. Which one to use depends on whether we need to preserve semantic validity for any existing mzMLs that put the ion mobility attributes in the selectedIon element. I'm not aware of any that do.
The CCS issue is a bit more complex, probably worth discussing on a call. I'll try to join.
Joshua pointed out that ion mobility attribute is in fact a scan attribute, and the ion selection attribute is appropriate for selectedIon when referring to the precursor's ion mobility. So this is a non-issue. Except for the CCS thing. As discussed on the PSI call I'll make a PR for co-parenting the CCS as an ion mobility attribute.
ProteoWizard has for years been writing the individual scan ion mobility CV terms in the wrong place (according to the mapping file), but I think it's the CV terms that should be changed. The CV has them as "ion selection attributes" which the mapping file only allows as a child of "selectedIon". MS1 spectra won't have a "selectedIon" (or a precursor), but MS1s are frequently still separated by ion mobility. ProteoWizard has been writing these terms in the element. Can we update this term to be a scan attribute, or perhaps both (for backward compatibility?). Or at least not somewhere that's not limited to MSn scans? I think my last message about this was sent to the vocab mailing list back in 2016, so obviously it isn't urgent, but it also shouldn't be hard to fix if a fix is warranted.
We should also consider putting "collisional cross section" in an attribute type that can go in the mzML somewhere. I'm not sure exactly where. It's a molecular property, but it's also possible to convert an instrument's mobility value to CCS if it's calibrated and you know the charge and gas and such. So theoretically a CCS could go anywhere a raw ion mobility value could go?
These terms would be affected: