search

HUPO-PSI / proxi-schemas

ProXI: Schema definitions for the Proteomics eXpression Interface
3 stars 3 forks source link

accession input and output #56

Closed edeutsch closed 4 years ago

edeutsch commented 4 years ago

/psms input has:

    - name: accession
      in: query 
      type: string 
      description: Dataset accession

But Psm output has:

  accession:
     type: string 
     description: Accession of the PSM

This is either confusing or an error.

I also suggest that "accession" is too vague. May I suggest datasetIdentifier? I suppose we use "accession" everywhere else. But I think this is vague and confusing. At bare minimum, we should not use access for a PSM accession.

How should we resolve?

ypriverol commented 4 years ago

Related with issue #55

edeutsch commented 4 years ago

my preferred solution is datasetIdentifier input and output and then a psmIdentifier if someone besides me thinks we need it (I don't think we do)

ypriverol commented 4 years ago

Solve in PR https://github.com/HUPO-PSI/proxi-schemas/pull/52