search

HUPO-PSI / proxi-schemas

ProXI: Schema definitions for the Proteomics eXpression Interface
3 stars 3 forks source link

default pageNumber? #58

Closed edeutsch closed 4 years ago

edeutsch commented 4 years ago

in /psms:

    - name: pageNumber
      in: query
      description: Current page to be shown paged psms (default page 1)
      required: false
      type: integer
      default: 0

is the default 0 or 1? schema says 0, but words say one. This occurs in multiple other places in the schema

Also, we should state clearly whether we are 0-based for page 1 and 1-based for page 1

ypriverol commented 4 years ago

Agree, If will refine this in the schema and correct that everywhere.

ypriverol commented 4 years ago

Solved in this PR https://github.com/HUPO-PSI/proxi-schemas/pull/52