search

HUPO-PSI / psi-mod-CV

Reactivated PSI-MOD ontology for molecular mass modifications
Creative Commons Attribution 4.0 International
7 stars 13 forks source link

Adding xrefs to UniProt's PTMList and publishing our first OWL #40

Closed pmt706 closed 3 years ago

pmt706 commented 3 years ago

This adds crossrefs to the UniProt PTMList (which has listed some xrefs to PSI-MOD). There are incorrect links on both sides that will be addressed once this first crossreference task is done.

edeutsch commented 3 years ago

What kind of review do you think it appropriate here? The diffs under [Files changed] are too big to display. I would need to start pulling down your fork and comparing, and honestly I wouldn't know a good owl file if I saw one.

pmt706 commented 3 years ago

Well, That's a good question. I think the best way to check for a well-formed OWL file would be to open it in something like Protege and make sure the file opens without error. The other thing that's in this PR is the XREFs, but those are just 1:1 with UniProt, so again, as long as the OBO/OWL opens in Protege, then I didn't mess up any of the formatting.

pmt706 commented 3 years ago

(and I know from experience, that syntax errors will cause the ROBOT Tool/Protege to crash or not open a file with often very poor tracing of where the exact offending line is!)

edeutsch commented 3 years ago

sure, go ahead and merge. I haven't been able to examine it, but am swamped at the moment, so go ahead. If there is a problem, we can do corrections later. Thanks!