HWComputerScience / iHW-iOS

iHW iOS App
4 stars 4 forks source link

Tapping the date select box brings up an unclosable box with no content #2

Closed jononon closed 9 years ago

jononon commented 10 years ago

The only way to close the box is to close the app and get rid of it in multitasking. This bug has been around for awhile. img_7198

jononon commented 10 years ago

This article is interesting: https://bugzilla.xamarin.com/show_bug.cgi?id=22586

It suggests that perhaps the line of code (iHWScheduleViewController.m):

- (IBAction)gotoDate:(id)sender {
    ActionSheetDatePicker *picker = [[ActionSheetDatePicker alloc] initWithTitle:@"Go to which date?" datePickerMode:UIDatePickerModeDate selectedDate:self.currentDate target:self action:@selector(showDayWithDate:) origin:self.toolbar];
    picker.doneButtonText = @"Go";
    [picker showActionSheetPicker];
}

needs to be amended, changed, or scrapped entirely. I'm working on it in my fork (http://github.com/jononon/iHW-iOS), and I'll see what I can do.

jburns20 commented 10 years ago

Thanks. If you fix it, make a pull request! I think the issue is that ActionSheetDatePicker needs an update: https://github.com/skywinder/ActionSheetPicker-3.0

cameronccohen commented 10 years ago

I actually already mostly fixed it, just need to make a pull request. It was working weirdly though, I got the picker to show properly (needed to install a new version of the UIActionSheet open source helper controller thing for iOS8) but when you pick a date it just is one day off so I need to fix that.

Cameron

On Nov 3, 2014, at 7:49 PM, Jonathan Burns notifications@github.com wrote:

Thanks. If you fix it, make a pull request!

— Reply to this email directly or view it on GitHub.

jononon commented 10 years ago

On my fork I already updated the ActionSheetDatePicker if you want.

jburns20 commented 9 years ago

Did this ever get fixed in the main repo?

jononon commented 9 years ago

I'm pretty sure the main is fixed.