search

HWComputerScience / iHW-iOS

iHW iOS App
4 stars 4 forks source link

Updated Code from ActionSheetPicker #3

Closed jononon closed 9 years ago

jononon commented 10 years ago

Updated the ActionSheetDatePicker, AbstractActionSheetPicker, and ActionSheetStringPicker to match http://github.com/TimCinel/ActionSheetPicker.

jburns20 commented 10 years ago

Could you try to fix the bug first?

jononon commented 10 years ago

Yeah sure.

jburns20 commented 10 years ago

Did you mean to add your email signature to your comment? This is a public repository.

jononon commented 10 years ago

Oops, thanks for notifying me.

jmfieldman commented 9 years ago

Should this still be merged?

jononon commented 9 years ago

Only if you want to update ActionSheetDatePicker, AbstractActionSheetPicker, and ActionSheetStringPicker to match http://github.com/TimCinel/ActionSheetPicker. Otherwise I'd say no. If it ain't broke...

jburns20 commented 9 years ago

Well on iOS 8 it is broke...

jmfieldman commented 9 years ago

so is that a yes or no? i just don't want to merge something that will break stuff going forward

jononon commented 9 years ago

No, don't merge it. Its not needed.