search

HWR-llc / ett

MassBays Phase I data explorer for data from the EPA WQX Portal
MIT License
1 stars 1 forks source link

diadromous fish habitat - radio button #73

Closed rhartzel closed 2 years ago

rhartzel commented 2 years ago

When hovering over the diad. fish radio button, you see "diadromous fish coming soon"...but if you click the button quickly (before the hover appears...about a 1 sec delay) there is no "coming soon" feedback.

I also noticed that if the words "diadromous fish" are clicked instead of the radio button, eelgrass habitat is selected.

HWR-llc commented 2 years ago

Thanks to both. I have fixed the key issue for all radio buttons now as mentioned in #66. Will close that issue.

For hovering, I was using the title tag for the hover tooltip. That works on both active elements (i.e., the Diadromous Fish text) and disabled elements (i.e., the Diadromous Fish radio button), but the tooltip for title only comes up if you hover and do not click. I can use a bootstrap-vue tooltip, but that only works on active elements. I've done that on the ETT so you can look at it. Without getting into coding a unique solution (not wanting to do that for something that is going to go away), I think our three options are:

  1. default title tooltip will show up on both disabled radio button and text, but won't show if someone clicks quickly.
  2. new tooltip will show up on text, even if the user clicks, but not on the radio button.
  3. new tooltip and enable the radio button so that tooltip shows on both radio button and text, but user can now select Diadromous Fish even though there is no information to show.

My vote is option 2, but I can go with consensus

walkerjeffd commented 2 years ago

I think the way it works now with the tooltip only on the label and the button being disable is good