search

HWXLR8 / beef-board

USB HID PCB for Bemani rhythm games
GNU General Public License v3.0
11 stars 2 forks source link

Upgrade to Svelte 5 #115

Open ASleepyCat opened 1 month ago

ASleepyCat commented 1 month ago

Svelte 5 finally has an official stable release (https://svelte.dev/blog/svelte-5-is-alive).

Hopefully will fix the double update bug.

ASleepyCat commented 3 weeks ago

Likely won't upgrade anytime soon as Svelte 5's new runes system breaks our current way of detecting a config update. Class property updates no longer trigger side effects on the class instance without some sort of wrapper.

If this proposal (https://github.com/sveltejs/svelte/issues/10560) gets implemented, I'll have another try at this. Otherwise, I don't exactly feel like adding a ton of boilerplate for an upgrade (or if there's a better way).

Edit: I could probably use proxies to reimplement this in Svelte 5 but it feels really hacky when I feel like this is exactly what signals are supposed to be for.