HXX97 / EDGQA

Codes for "EDG-based Question Decomposition for Complex Question Answering over Knowledge Bases"
GNU General Public License v3.0
12 stars 5 forks source link

Add check of withStdOutMap.get(writer) when decide whether to execute System.out.print(str) #2

Closed scarlettllc closed 3 years ago

scarlettllc commented 3 years ago

In the file "main/src/main/java/cn/edu/nju/ws/edgqa/utils/LogUtil.java", in the function "public static void print(String writer, String str, LogType logType)", it's better to use "withStdOutMap.containsKey(writer) && withStdOutMap.get(writer)" instead of only "withStdOutMap.containsKey(writer)" to decide whether to execute the code "System.out.print(str)". Otherwise, the variable "withStdOut" doesn't play its due role and seems redundant.

yhshu commented 3 years ago

Problem fixed.