rugiraprince.md - Githubissues

HYF-Class22 / home

Home repository for HYF class 22

https://hyf-class22.github.io/home/

MIT License

0 stars 5 forks source link

rugiraprince.md #62

Closed rugiraprince closed 10 months ago

rugiraprince commented 10 months ago

Checklists

General Checks

[x] the branch is up to date with main/master
[x] the code works when pulled and run locally
[x] All CI checks pass
[x] all conflicts are resolved (if any)
[x] PR has a descriptive title
[x] PR has appropriate labels and milestones for easy identification
[x] PR it is assigned to the owner
[x] reviewers are assigned
[x] the PR contributes only one focused change
[x] It is in the appropriate column in the project board (if necessary)
[x] has short and clear description
[x] is linked to an issue (if it is related)
[x] feedback is addressed (if any and if it is appropriate feedback.)

Markdown

[x] the markdown source is formatted
[x] spelling and grammar is correct in all text
[x] The markdown looks correct when you preview the file
[x] all links and images work
[x] any embedded code snippets are formatted

rugiraprince commented 10 months ago

@samirm00 i get it so apart from what else can i do ? i don't know why its says all checks have failed??

sammou00 commented 10 months ago

@rugiraprince you have many header 1 in your file that is not allowed , you only can have one Header 1

rugiraprince commented 10 months ago

hey @samirm00 in had changed everything but now i have to make change to a file normally i am not suppose to change ? what can i do ?

bermarte commented 10 months ago

You need to run the npm scripts you find in package.json. When adding files, please add one file at a time and avoid this:

npm add .

use this instead

npm add <filename>

You have changed also other files of the repo.

bermarte commented 10 months ago

had changed everything but now i have to make change to a file normally i am not suppose to change ? what can i do ?

The best strategy is to switch to your branch and merge the files you changed from the main branch to your branch; it's like copying the files from a location to another.

git merge package.json, file2, file3

If you want we can do it together tomorrow.

bermarte commented 10 months ago

The best way to copy a file from main to your branch is to merge that file in your branch, tomorrow I can help you, just tag me on Slack.

git checkout <your_branch>
git merge <file_to_be_copied>

bermarte commented 10 months ago

The texts of your commits are not informative, they don't describe what you did. We will have a look at it together.

bermarte commented 10 months ago

@rugiraprince You should always interact with the coaches, please leave feedback.

rugiraprince commented 10 months ago

@bermarte i just came from work now i read all your message and i realise i had been using some wrong command that why i was trying to delete the pull request so i can start from zero

rugiraprince commented 10 months ago

@bermarte is it ok can i delete the pull request and branch?