HYsxe / PRINT

33 stars 3 forks source link

Package dependency for BuenRTools #5

Closed cemmeydan closed 1 year ago

cemmeydan commented 1 year ago

Hi, Various functions and scripts (filterPeaks, filterFrags etc.) reference the BuenRTools library, which I couldn't find in Buenrostro lab or any other place. Is it available anywhere? Or Is there at least a description of the methods to replicate the code?

Thank you,

HYsxe commented 1 year ago

Hi!

Thanks for pointing this out! I will add those functions to our code base and let you know when I'm done!

HYsxe commented 1 year ago

Ok I have added those functions to utils.R and updated references to these functions in other scripts. Could you give the updated codes a try?

cemmeydan commented 1 year ago

Thank you.

Also few small issues that were trivial to fix.

Thank you,

HYsxe commented 1 year ago

I have just updated the above BuenRTools references and now just doing a quick search I think there shouldn't be any BuenRTools:: left. And yeah I think the most ideal case would be to make this into a package which is still on our to-do list. For the current version, we have a recommended folder structure in our tutorial. I think if you try that it should be able to find all the files. Let me know if these updates work!