HZ-HBO-ICT / it-conference

Official repository for the IT-Conference
https://weareinittogether.nl
MIT License
5 stars 0 forks source link

Bugfix - GitHub actions #382

Closed v-stamenova closed 3 months ago

v-stamenova commented 3 months ago

Description

The migration that we are currently doing breaks the current github actions/workflows. The branch will try to fix the issues.

From #256

Currently, our GitHub Actions workflows are pretty arbitrary. They fire off on every push and continue testing even if previous ones failed. Although unlimited on public repositories, it might cause some issues in the long term with the organization's billable runner credits. Suggestions as follows:

  • Only trigger workflows manually or on a pull request.
  • Limit testing NodeJS versions to the one used in production, instead of 18x and 20x simultaneously.
  • Only fire PHPCS when the main test suite passes.
  • Add a secondary check in the release workflow that prevents the build if tests fail, as currently there seems to be no protection against that.

Local testing remains quicker and more efficient than starting up a GitHub Runner every time, even for a slight grammar fix. It won't make or break the codebase, but it will improve the CI/CD pipeline a good bit.

The current state of the PR fixes the first two issues:

closes #376

Type of change

What needs to be tested

GitHub Actions should be able to provide testing for this one.

Checklist:

github-actions[bot] commented 3 months ago

Coverage report for commit: a1a5427 File: coverage.xml

Cover ┌─────────────────────────┐ Freq.
   0% │ ███████████████████████ │ 83.8%
  10% │ █░░░░░░░░░░░░░░░░░░░░░░ │  1.0%
  20% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  30% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  40% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  50% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  60% │ █░░░░░░░░░░░░░░░░░░░░░░ │  1.0%
  70% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  80% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  90% │ █░░░░░░░░░░░░░░░░░░░░░░ │  1.0%
 100% │ ████░░░░░░░░░░░░░░░░░░░ │ 13.1%
      └─────────────────────────┘
 *Legend:* █ = Current Distribution 
Summary - Lines: 9.23% | Methods: 6.42%
FilesLinesMethodsBranches
app/Actions/Fortify
   CreateNewUser.php100.00%100.00%100.00%
   PasswordValidationRules.php100.00%100.00%100.00%
   ResetUserPassword.php100.00%100.00%100.00%
   UpdateUserPassword.php100.00%100.00%100.00%
   UpdateUserProfileInformation.php60.00%-100.00%
app/Actions/Jetstream
   DeleteUser.php100.00%100.00%100.00%
app/Console/Commands
   AddSpeakerToPresentation.php--100.00%
   AddToHz.php--100.00%
   ConfirmAllEmails.php--100.00%
   CreateAdmin.php--100.00%
   ModifyTimeslotDuration.php--100.00%
   UpsertMasterData.php--100.00%
app/Events
   FinalProgrammeReleased.php--100.00%
app/Http/Controllers
   CompanyController.php--100.00%
   Controller.php100.00%100.00%100.00%
   HomeController.php100.00%100.00%100.00%
   SpeakerController.php--100.00%
app/Http/Livewire
   AuthNavigationMenu.php--100.00%
   BoothRequest.php--100.00%
   DownloadPresentation.php--100.00%
   EditTeamModal.php--100.00%
   EmailNotificationPreference.php--100.00%
   GuestNavigationMenu.php--100.00%
   ManageCompanyLogo.php--100.00%
   NotificationsList.php--100.00%
   OverrideDifficulty.php--100.00%
   ReleaseFinalProgramme.php--100.00%
   RoomAndTimeslotSelector.php--100.00%
   ShowNotification.php--100.00%
   SponsorshipRequest.php--100.00%
   UploadPresentation.php--100.00%
app/Http/Livewire/Booths
   DeleteBoothForm.php--100.00%
   EditBoothModal.php--100.00%
app/Http/Livewire/Companies
   DeleteCompanyForm.php--100.00%
app/Http/Livewire/DefaultPresentations
   EditDefaultPresentationForm.php--100.00%
app/Http/Livewire/Presentations
   DeletePresentationForm.php--100.00%
   EditPresentationModal.php--100.00%
app/Http/Livewire/Rooms
   DeleteRoomForm.php--100.00%
app/Http/Livewire/Schedule
   AddTimeslotPadding.php--100.00%
   RemovePresentationFromSchedule.php--100.00%
   ReplacePresentation.php--100.00%
   ResetTimeslots.php--100.00%
app/Http/Livewire/Sponsorships
   CreateSponsorshipForm.php--100.00%
   DeleteSponsorshipForm.php--100.00%
app/Http/Livewire/Users
   DeleteUserForm.php--100.00%
app/Listeners
   HandleFinalProgrammeReleased.php--100.00%
app/Livewire
   AuthNavigationMenu.php100.00%100.00%100.00%
   EmailNotificationPreference.php--100.00%
   GuestNavigationMenu.php100.00%100.00%100.00%
app/Mail
   BoothApprovedMailable.php--100.00%
   BoothDisapprovedMailable.php--100.00%
   CustomTeamInvitation.php--100.00%
   GenericNewUpdatesMailable.php--100.00%
   InviteCompany.php--100.00%
   InviteUser.php--100.00%
   PresentationApprovedMailable.php--100.00%
   PresentationDisapprovedMailable.php--100.00%
   SponsorshipApprovedMailable.php--100.00%
   SponsorshipDisapprovedMailable.php--100.00%
   TeamApprovedMailable.php--100.00%
   TeamDisapprovedMailable.php--100.00%
app/Models
   EventInstance.php--100.00%
   User.php100.00%100.00%100.00%
app/Notifications
   NotifyBoothApproved.php--100.00%
   NotifyBoothDisapproved.php--100.00%
   NotifyPresentationApproved.php--100.00%
   NotifyPresentationDisapproved.php--100.00%
   NotifySponsorshipApproved.php--100.00%
   NotifySponsorshipDisapproved.php--100.00%
   NotifyTeamApproved.php--100.00%
   NotifyTeamDisapproved.php--100.00%
app/Observers
   BoothObserver.php--100.00%
   SpeakerObserver.php--100.00%
   TeamObserver.php--100.00%
app/Policies
   PresentationPolicy.php--100.00%
   TeamPolicy.php--100.00%
   UserPolicy.php14.29%14.29%100.00%
app/Providers
   AppServiceProvider.php100.00%100.00%100.00%
   FortifyServiceProvider.php91.67%50.00%100.00%
   JetstreamServiceProvider.php100.00%100.00%100.00%
app/View/Components
   AppLayout.php100.00%100.00%100.00%
   CompanyDashboardSection.php--100.00%
   CompanyRepBlock.php--100.00%
   ContentModBoothRequestDetails.php--100.00%
   ContentModCompanyRequestDetails.php--100.00%
   ContentModPresentationRequestDetails.php--100.00%
   ContentModSponsorRequestDetails.php--100.00%
   ContentModeratorBlock.php--100.00%
   ContentModeratorDashboard.php--100.00%
   EnrollModal.php--100.00%
   GoldSponsorSpeakerBlock.php--100.00%
   GuestLayout.php--100.00%
   HubLayout.php--100.00%
   HzTeamBlock.php--100.00%
   Map.php--100.00%
   PresentationDetails.php--100.00%
   ScheduleBlock.php--100.00%
   SidebarLink.php--100.00%
   SidebarLinkContentMod.php--100.00%

:robot: comment via lucassabreu/comment-coverage-clover