HZ-HBO-ICT / it-conference

Official repository for the IT-Conference
https://weareinittogether.nl
MIT License
5 stars 0 forks source link

Rework - Login and registration #395

Closed v-stamenova closed 2 months ago

v-stamenova commented 2 months ago

Description

The branch introduces design changes on the login and registration pages

closes #352, #198

Type of change

What needs to be tested

Checklist:

github-actions[bot] commented 2 months ago

Coverage report for commit: b8b4fdb File: coverage.xml

Cover ┌─────────────────────────┐ Freq.
   0% │ ███████████████████████ │ 82.5%
  10% │ █░░░░░░░░░░░░░░░░░░░░░░ │  1.7%
  20% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  30% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  40% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  50% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  60% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  70% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  80% │ █░░░░░░░░░░░░░░░░░░░░░░ │  1.7%
  90% │ █░░░░░░░░░░░░░░░░░░░░░░ │  2.5%
 100% │ ████░░░░░░░░░░░░░░░░░░░ │ 11.7%
      └─────────────────────────┘
 *Legend:* █ = Current Distribution 
Summary - Lines: 20.31% | Methods: 9.33%
FilesLinesMethodsBranches
app/Actions/Fortify
   CreateNewUser.php98.48%50.00%100.00%
   PasswordValidationRules.php100.00%100.00%100.00%
   ResetUserPassword.php100.00%100.00%100.00%
   UpdateUserPassword.php100.00%100.00%100.00%
   UpdateUserProfileInformation.php75.00%50.00%100.00%
app/Actions/Jetstream
   DeleteUser.php100.00%100.00%100.00%
app/Console/Commands
   AddSpeakerToPresentation.php--100.00%
   AddToHz.php--100.00%
   ConfirmAllEmails.php--100.00%
   CreateAdmin.php7.69%33.33%100.00%
   ModifyTimeslotDuration.php--100.00%
   UpsertMasterData.php88.24%40.00%100.00%
app/Events
   FinalProgrammeReleased.php--100.00%
app/Http/Controllers
   CompanyController.php--100.00%
   Controller.php100.00%100.00%100.00%
   HomeController.php100.00%100.00%100.00%
   HubController.php--100.00%
   InvitationController.php--100.00%
   SpeakerController.php--100.00%
app/Http/Livewire
   AuthNavigationMenu.php--100.00%
   DownloadPresentation.php--100.00%
   EmailNotificationPreference.php--100.00%
   GuestNavigationMenu.php--100.00%
   NotificationsList.php--100.00%
   OverrideDifficulty.php--100.00%
   ReleaseFinalProgramme.php--100.00%
   RoomAndTimeslotSelector.php--100.00%
   ShowNotification.php--100.00%
   UploadPresentation.php--100.00%
app/Http/Livewire/Booths
   DeleteBoothForm.php--100.00%
   EditBoothModal.php--100.00%
app/Http/Livewire/Companies
   DeleteCompanyForm.php--100.00%
app/Http/Livewire/DefaultPresentations
   EditDefaultPresentationForm.php--100.00%
app/Http/Livewire/Presentations
   DeletePresentationForm.php--100.00%
   EditPresentationModal.php--100.00%
app/Http/Livewire/Rooms
   DeleteRoomForm.php--100.00%
app/Http/Livewire/Schedule
   AddTimeslotPadding.php--100.00%
   RemovePresentationFromSchedule.php--100.00%
   ReplacePresentation.php--100.00%
   ResetTimeslots.php--100.00%
app/Http/Livewire/Sponsorships
   CreateSponsorshipForm.php--100.00%
   DeleteSponsorshipForm.php--100.00%
app/Http/Livewire/Users
   DeleteUserForm.php--100.00%
app/Listeners
   HandleFinalProgrammeReleased.php--100.00%
app/Livewire
   AuthNavigationMenu.php100.00%100.00%100.00%
   EmailNotificationPreference.php--100.00%
   GuestNavigationMenu.php100.00%100.00%100.00%
app/Livewire/Company
   AddMember.php--100.00%
   BoothRequest.php--100.00%
   DeleteCompany.php--100.00%
   DetailsForm.php--100.00%
   EditCompanyModal.php--100.00%
   ManageLogo.php--100.00%
   MemberManager.php--100.00%
   RemoveMember.php--100.00%
   SponsorshipRequest.php--100.00%
   UpdateMemberRole.php--100.00%
app/Livewire/Forms
   CompanyForm.php--100.00%
app/Livewire/Helpers
   SimpleDialog.php100.00%100.00%100.00%
app/Mail
   BoothApprovedMailable.php--100.00%
   BoothDisapprovedMailable.php--100.00%
   CustomTeamInvitation.php--100.00%
   GenericNewUpdatesMailable.php--100.00%
   InviteCompany.php--100.00%
   InviteUser.php--100.00%
   PresentationApprovedMailable.php--100.00%
   PresentationDisapprovedMailable.php--100.00%
   SponsorshipApprovedMailable.php--100.00%
   SponsorshipDisapprovedMailable.php--100.00%
   TeamApprovedMailable.php--100.00%
   TeamDisapprovedMailable.php--100.00%
app/Models
   Booth.php--100.00%
   Company.php--100.00%
   Difficulty.php--100.00%
   EventInstance.php--100.00%
   FrequentQuestion.php100.00%100.00%100.00%
   Invitation.php--100.00%
   Presentation.php76.47%42.86%100.00%
   Room.php--100.00%
   Sponsorship.php--100.00%
   Timeslot.php--100.00%
   User.php89.13%87.50%100.00%
   UserPresentation.php--100.00%
app/Notifications
   NotifyBoothApproved.php--100.00%
   NotifyBoothDisapproved.php--100.00%
   NotifyPresentationApproved.php--100.00%
   NotifyPresentationDisapproved.php--100.00%
   NotifySponsorshipApproved.php--100.00%
   NotifySponsorshipDisapproved.php--100.00%
   NotifyTeamApproved.php--100.00%
   NotifyTeamDisapproved.php--100.00%
app/Observers
   BoothObserver.php--100.00%
   SpeakerObserver.php--100.00%
   TeamObserver.php--100.00%
app/Policies
   CompanyPolicy.php--100.00%
   PresentationPolicy.php--100.00%
   TeamPolicy.php--100.00%
   UserPolicy.php14.29%14.29%100.00%
app/Providers
   AppServiceProvider.php100.00%100.00%100.00%
   FortifyServiceProvider.php91.67%50.00%100.00%
   JetstreamServiceProvider.php100.00%100.00%100.00%
app/View/Components
   AppLayout.php100.00%100.00%100.00%
   ContentModBoothRequestDetails.php--100.00%
   ContentModCompanyRequestDetails.php--100.00%
   ContentModPresentationRequestDetails.php--100.00%
   ContentModSponsorRequestDetails.php--100.00%
   ContentModeratorBlock.php--100.00%
   ContentModeratorDashboard.php--100.00%
   EnrollModal.php--100.00%
   GoldSponsorSpeakerBlock.php--100.00%
   GuestLayout.php--100.00%
   HubLayout.php--100.00%
   HzTeamBlock.php--100.00%
   Map.php--100.00%
   PresentationDetails.php--100.00%
   ScheduleBlock.php--100.00%
   SidebarLink.php--100.00%
   SidebarLinkContentMod.php--100.00%
app/View/Components/Dashboards/Blocks
   Company.php--100.00%
app/View/Components/Dashboards
   Company.php--100.00%

:robot: comment via lucassabreu/comment-coverage-clover

TimKardol commented 2 months ago

General Feedback

v-stamenova commented 2 months ago

General Feedback

  • The 'modal' takes too much space from the page. I think the way to go about is by implementing some sort of pagination/stages when registering as a company. Sort of along the lines of this: https://www.w3schools.com/howto/howto_js_form_steps.asp
  • Because the company rep is taking so much space. When you switch between participant and company rep the switch jumps around and doesn't stay in the right place.

I'll see what I can do but I am not very inclined to send requests via pure js. I'll play with Livewire once I resolve the modal issue.

TimKardol commented 2 months ago

General Feedback

  • The 'modal' takes too much space from the page. I think the way to go about is by implementing some sort of pagination/stages when registering as a company. Sort of along the lines of this: https://www.w3schools.com/howto/howto_js_form_steps.asp
  • Because the company rep is taking so much space. When you switch between participant and company rep the switch jumps around and doesn't stay in the right place.

I'll see what I can do but I am not very inclined to send requests via pure js. I'll play with Livewire once I resolve the modal issue.

Yeah I agree with the request. It's more about the design. But I think then it automatically needs to be done with livewire. Design wise @popo0015 could maybe create something.

v-stamenova commented 2 months ago

General Feedback

  • The 'modal' takes too much space from the page. I think the way to go about is by implementing some sort of pagination/stages when registering as a company. Sort of along the lines of this: https://www.w3schools.com/howto/howto_js_form_steps.asp
  • Because the company rep is taking so much space. When you switch between participant and company rep the switch jumps around and doesn't stay in the right place.

I'll see what I can do but I am not very inclined to send requests via pure js. I'll play with Livewire once I resolve the modal issue.

Yeah I agree with the request. It's more about the design. But I think then it automatically needs to be done with livewire. Design wise @popo0015 could maybe create something.

With @IGORnvk we will try to figure out the flow, and hopefully after that @popo0015 can throw a design idea to implement