Closed v-stamenova closed 2 months ago
Coverage report for commit: b8b4fdb
File: coverage.xml
Cover ┌─────────────────────────┐ Freq.
0% │ ███████████████████████ │ 82.5%
10% │ █░░░░░░░░░░░░░░░░░░░░░░ │ 1.7%
20% │ ░░░░░░░░░░░░░░░░░░░░░░░ │ 0.0%
30% │ ░░░░░░░░░░░░░░░░░░░░░░░ │ 0.0%
40% │ ░░░░░░░░░░░░░░░░░░░░░░░ │ 0.0%
50% │ ░░░░░░░░░░░░░░░░░░░░░░░ │ 0.0%
60% │ ░░░░░░░░░░░░░░░░░░░░░░░ │ 0.0%
70% │ ░░░░░░░░░░░░░░░░░░░░░░░ │ 0.0%
80% │ █░░░░░░░░░░░░░░░░░░░░░░ │ 1.7%
90% │ █░░░░░░░░░░░░░░░░░░░░░░ │ 2.5%
100% │ ████░░░░░░░░░░░░░░░░░░░ │ 11.7%
└─────────────────────────┘
*Legend:* █ = Current Distribution
:robot: comment via lucassabreu/comment-coverage-clover
General Feedback
General Feedback
- The 'modal' takes too much space from the page. I think the way to go about is by implementing some sort of pagination/stages when registering as a company. Sort of along the lines of this: https://www.w3schools.com/howto/howto_js_form_steps.asp
- Because the company rep is taking so much space. When you switch between participant and company rep the switch jumps around and doesn't stay in the right place.
I'll see what I can do but I am not very inclined to send requests via pure js. I'll play with Livewire once I resolve the modal issue.
General Feedback
- The 'modal' takes too much space from the page. I think the way to go about is by implementing some sort of pagination/stages when registering as a company. Sort of along the lines of this: https://www.w3schools.com/howto/howto_js_form_steps.asp
- Because the company rep is taking so much space. When you switch between participant and company rep the switch jumps around and doesn't stay in the right place.
I'll see what I can do but I am not very inclined to send requests via pure js. I'll play with Livewire once I resolve the modal issue.
Yeah I agree with the request. It's more about the design. But I think then it automatically needs to be done with livewire. Design wise @popo0015 could maybe create something.
General Feedback
- The 'modal' takes too much space from the page. I think the way to go about is by implementing some sort of pagination/stages when registering as a company. Sort of along the lines of this: https://www.w3schools.com/howto/howto_js_form_steps.asp
- Because the company rep is taking so much space. When you switch between participant and company rep the switch jumps around and doesn't stay in the right place.
I'll see what I can do but I am not very inclined to send requests via pure js. I'll play with Livewire once I resolve the modal issue.
Yeah I agree with the request. It's more about the design. But I think then it automatically needs to be done with livewire. Design wise @popo0015 could maybe create something.
With @IGORnvk we will try to figure out the flow, and hopefully after that @popo0015 can throw a design idea to implement
Description
The branch introduces design changes on the login and registration pages
closes #352, #198
Type of change
What needs to be tested
Checklist: