HZ-HBO-ICT / it-conference

Official repository for the IT-Conference
https://weareinittogether.nl
MIT License
5 stars 0 forks source link

Bugfix - Profile picture filtering #404

Closed v-stamenova closed 1 month ago

v-stamenova commented 2 months ago

Description

This branch introduces a bug fix on a security issue when uploading a picture/presentation. For both cases there was a back-end validation to check for the type that had been uploaded, but there was no filtering when the user was selecting the files themselves. The changes introduced here are fixing exactly that.

closes #350

Type of change

What needs to be tested

Checklist:

github-actions[bot] commented 2 months ago

Coverage report for commit: 0c7eae7 File: coverage.xml

Cover ┌─────────────────────────┐ Freq.
   0% │ ███████████████████████ │ 84.4%
  10% │ █░░░░░░░░░░░░░░░░░░░░░░ │  1.6%
  20% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  30% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  40% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  50% │ █░░░░░░░░░░░░░░░░░░░░░░ │  0.8%
  60% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  70% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  80% │ █░░░░░░░░░░░░░░░░░░░░░░ │  0.8%
  90% │ █░░░░░░░░░░░░░░░░░░░░░░ │  2.3%
 100% │ ███░░░░░░░░░░░░░░░░░░░░ │ 10.2%
      └─────────────────────────┘
 *Legend:* █ = Current Distribution 
Summary - Lines: 17.87% | Methods: 8.09%
FilesLinesMethodsBranches
app/Actions/Fortify
   CreateNewUser.php98.33%50.00%100.00%
   PasswordValidationRules.php100.00%100.00%100.00%
   ResetUserPassword.php100.00%100.00%100.00%
   UpdateUserPassword.php100.00%100.00%100.00%
   UpdateUserProfileInformation.php75.00%50.00%100.00%
app/Actions/Jetstream
   DeleteUser.php100.00%100.00%100.00%
app/Console/Commands
   AddSpeakerToPresentation.php--100.00%
   AddToHz.php--100.00%
   ConfirmAllEmails.php--100.00%
   CreateAdmin.php7.69%33.33%100.00%
   ModifyTimeslotDuration.php--100.00%
   UpsertMasterData.php88.24%40.00%100.00%
app/Events
   FinalProgrammeReleased.php--100.00%
app/Http/Controllers
   CompanyController.php--100.00%
   Controller.php100.00%100.00%100.00%
   HomeController.php100.00%100.00%100.00%
   HubController.php--100.00%
   InvitationController.php--100.00%
   PresentationController.php--100.00%
   RegistrationController.php--100.00%
   SpeakerController.php--100.00%
app/Http/Livewire
   AuthNavigationMenu.php--100.00%
   DownloadPresentation.php--100.00%
   EmailNotificationPreference.php--100.00%
   GuestNavigationMenu.php--100.00%
   NotificationsList.php--100.00%
   OverrideDifficulty.php--100.00%
   ReleaseFinalProgramme.php--100.00%
   RoomAndTimeslotSelector.php--100.00%
   ShowNotification.php--100.00%
app/Http/Livewire/Booths
   DeleteBoothForm.php--100.00%
   EditBoothModal.php--100.00%
app/Http/Livewire/Companies
   DeleteCompanyForm.php--100.00%
app/Http/Livewire/DefaultPresentations
   EditDefaultPresentationForm.php--100.00%
app/Http/Livewire/Presentations
   DeletePresentationForm.php--100.00%
   EditPresentationModal.php--100.00%
app/Http/Livewire/Rooms
   DeleteRoomForm.php--100.00%
app/Http/Livewire/Schedule
   AddTimeslotPadding.php--100.00%
   RemovePresentationFromSchedule.php--100.00%
   ReplacePresentation.php--100.00%
   ResetTimeslots.php--100.00%
app/Http/Livewire/Sponsorships
   CreateSponsorshipForm.php--100.00%
   DeleteSponsorshipForm.php--100.00%
app/Http/Livewire/Users
   DeleteUserForm.php--100.00%
app/Listeners
   HandleFinalProgrammeReleased.php--100.00%
app/Livewire
   AuthNavigationMenu.php100.00%100.00%100.00%
   EmailNotificationPreference.php--100.00%
   GuestNavigationMenu.php100.00%100.00%100.00%
app/Livewire/Company
   AddMember.php--100.00%
   BoothRequest.php--100.00%
   DeleteCompany.php--100.00%
   DetailsForm.php--100.00%
   EditCompanyModal.php--100.00%
   ManageLogo.php--100.00%
   MemberManager.php--100.00%
   RemoveMember.php--100.00%
   SponsorshipRequest.php--100.00%
   UpdateMemberRole.php--100.00%
app/Livewire/Forms
   CompanyForm.php--100.00%
   PresentationForm.php--100.00%
app/Livewire/Presentation
   DeletePresentationModal.php--100.00%
   EditPresentationModal.php--100.00%
   UploadPresentation.php--100.00%
app/Livewire/Registration
   CompanyBasicForm.php--100.00%
   CompanyLocationForm.php--100.00%
   CompanyRepresentativeForm.php--100.00%
   ParentComponent.php--100.00%
app/Mail
   BoothApprovedMailable.php--100.00%
   BoothDisapprovedMailable.php--100.00%
   CustomTeamInvitation.php--100.00%
   GenericNewUpdatesMailable.php--100.00%
   InviteCompany.php--100.00%
   InviteUser.php--100.00%
   PresentationApprovedMailable.php--100.00%
   PresentationDisapprovedMailable.php--100.00%
   SponsorshipApprovedMailable.php--100.00%
   SponsorshipDisapprovedMailable.php--100.00%
   TeamApprovedMailable.php--100.00%
   TeamDisapprovedMailable.php--100.00%
app/Models
   Booth.php--100.00%
   Company.php--100.00%
   Difficulty.php--100.00%
   EventInstance.php--100.00%
   FrequentQuestion.php100.00%100.00%100.00%
   Invitation.php--100.00%
   Presentation.php54.17%37.50%100.00%
   Room.php--100.00%
   Sponsorship.php--100.00%
   Timeslot.php--100.00%
   User.php89.13%87.50%100.00%
   UserPresentation.php--100.00%
app/Notifications
   NotifyBoothApproved.php--100.00%
   NotifyBoothDisapproved.php--100.00%
   NotifyPresentationApproved.php--100.00%
   NotifyPresentationDisapproved.php--100.00%
   NotifySponsorshipApproved.php--100.00%
   NotifySponsorshipDisapproved.php--100.00%
   NotifyTeamApproved.php--100.00%
   NotifyTeamDisapproved.php--100.00%
app/Observers
   BoothObserver.php--100.00%
   SpeakerObserver.php--100.00%
   TeamObserver.php--100.00%
app/Policies
   CompanyPolicy.php--100.00%
   PresentationPolicy.php--100.00%
   TeamPolicy.php--100.00%
   UserPolicy.php14.29%14.29%100.00%
app/Providers
   AppServiceProvider.php100.00%100.00%100.00%
   FortifyServiceProvider.php91.67%50.00%100.00%
   JetstreamServiceProvider.php100.00%100.00%100.00%
app/View/Components
   AppLayout.php100.00%100.00%100.00%
   ContentModBoothRequestDetails.php--100.00%
   ContentModCompanyRequestDetails.php--100.00%
   ContentModPresentationRequestDetails.php--100.00%
   ContentModSponsorRequestDetails.php--100.00%
   ContentModeratorBlock.php--100.00%
   ContentModeratorDashboard.php--100.00%
   EnrollModal.php--100.00%
   GoldSponsorSpeakerBlock.php--100.00%
   GuestLayout.php--100.00%
   HubLayout.php--100.00%
   HzTeamBlock.php--100.00%
   Map.php--100.00%
   PresentationDetails.php--100.00%
   ScheduleBlock.php--100.00%
   SidebarLink.php--100.00%
   SidebarLinkContentMod.php--100.00%
app/View/Components/Dashboards/Blocks
   Company.php--100.00%
app/View/Components/Dashboards
   Company.php--100.00%

:robot: comment via lucassabreu/comment-coverage-clover