HZ-HBO-ICT / it-conference

Official repository for the IT-Conference
https://weareinittogether.nl
MIT License
5 stars 0 forks source link

Feature - Multiple editions #412

Closed IGORnvk closed 1 week ago

IGORnvk commented 1 month ago

Description

Pull request introduces an edition management feature as well as the deadlines for the edition.

ERD for this particular part of the application: image

editions - previously called 'event_instance', represents edition (e.g. We are in IT together Conference 2024) events - basically representing all the events that occur during the conference (e.g. Company registration, Presentation request etc.) edition_events - table that connects events and edition during which these events are happening, and therefore it contains start and end dates for these events, since for every edition they can be different.

Note 1: the icons for editions/events should be changed, since I just copied them from another part of the application.

Note 2: 99% that I forgot to add something somewhere, so feel free to correct me.

closes #410 and #325

Type of change

What needs to be tested

Checklist:

github-actions[bot] commented 1 month ago

Coverage report for commit: c6bc98d File: coverage.xml

Cover ┌─────────────────────────┐ Freq.
   0% │ ███████████████████████ │ 85.4%
  10% │ █░░░░░░░░░░░░░░░░░░░░░░ │  1.5%
  20% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  30% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  40% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  50% │ █░░░░░░░░░░░░░░░░░░░░░░ │  0.7%
  60% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  70% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  80% │ █░░░░░░░░░░░░░░░░░░░░░░ │  0.7%
  90% │ █░░░░░░░░░░░░░░░░░░░░░░ │  2.2%
 100% │ ███░░░░░░░░░░░░░░░░░░░░ │  9.5%
      └─────────────────────────┘
 *Legend:* █ = Current Distribution 
Summary - Lines: 16.72% | Methods: 7.46%
FilesLinesMethodsBranches
app/Actions/Fortify
   CreateNewUser.php98.33%50.00%100.00%
   PasswordValidationRules.php100.00%100.00%100.00%
   ResetUserPassword.php100.00%100.00%100.00%
   UpdateUserPassword.php100.00%100.00%100.00%
   UpdateUserProfileInformation.php75.00%50.00%100.00%
app/Actions/Jetstream
   DeleteUser.php100.00%100.00%100.00%
app/Console/Commands
   AddSpeakerToPresentation.php--100.00%
   AddToHz.php--100.00%
   ConfirmAllEmails.php--100.00%
   CreateAdmin.php7.69%33.33%100.00%
   ModifyTimeslotDuration.php--100.00%
   UpsertMasterData.php88.24%40.00%100.00%
app/Events
   FinalProgrammeReleased.php--100.00%
app/Http/Controllers
   CompanyController.php--100.00%
   Controller.php100.00%100.00%100.00%
   EditionController.php--100.00%
   EditionEventController.php--100.00%
   HomeController.php100.00%100.00%100.00%
   HubController.php--100.00%
   InvitationController.php--100.00%
   PresentationController.php--100.00%
   RegistrationController.php--100.00%
   SpeakerController.php--100.00%
app/Http/Livewire
   AuthNavigationMenu.php--100.00%
   DownloadPresentation.php--100.00%
   EmailNotificationPreference.php--100.00%
   GuestNavigationMenu.php--100.00%
   NotificationsList.php--100.00%
   OverrideDifficulty.php--100.00%
   ReleaseFinalProgramme.php--100.00%
   RoomAndTimeslotSelector.php--100.00%
   ShowNotification.php--100.00%
app/Http/Livewire/Booths
   DeleteBoothForm.php--100.00%
   EditBoothModal.php--100.00%
app/Http/Livewire/Companies
   DeleteCompanyForm.php--100.00%
app/Http/Livewire/DefaultPresentations
   EditDefaultPresentationForm.php--100.00%
app/Http/Livewire/Presentations
   DeletePresentationForm.php--100.00%
   EditPresentationModal.php--100.00%
app/Http/Livewire/Rooms
   DeleteRoomForm.php--100.00%
app/Http/Livewire/Schedule
   AddTimeslotPadding.php--100.00%
   RemovePresentationFromSchedule.php--100.00%
   ReplacePresentation.php--100.00%
   ResetTimeslots.php--100.00%
app/Http/Livewire/Sponsorships
   CreateSponsorshipForm.php--100.00%
   DeleteSponsorshipForm.php--100.00%
app/Http/Livewire/Users
   DeleteUserForm.php--100.00%
app/Http/Middleware
   ContentModeratorMiddleware.php--100.00%
app/Listeners
   HandleFinalProgrammeReleased.php--100.00%
app/Livewire
   AuthNavigationMenu.php100.00%100.00%100.00%
   EmailNotificationPreference.php--100.00%
   GuestNavigationMenu.php100.00%100.00%100.00%
app/Livewire/Company
   AddMember.php--100.00%
   BoothRequest.php--100.00%
   DeleteCompany.php--100.00%
   DetailsForm.php--100.00%
   EditCompanyModal.php--100.00%
   ManageLogo.php--100.00%
   MemberManager.php--100.00%
   RemoveMember.php--100.00%
   SponsorshipRequest.php--100.00%
   UpdateMemberRole.php--100.00%
app/Livewire/Edition
   EditEditionModal.php--100.00%
app/Livewire/EditionEvent
   EditEditionEventModal.php--100.00%
app/Livewire/Forms
   CompanyForm.php--100.00%
   EditionEventForm.php--100.00%
   EditionForm.php--100.00%
   PresentationForm.php--100.00%
app/Livewire/Presentation
   DeletePresentationModal.php--100.00%
   EditPresentationModal.php--100.00%
   UploadPresentation.php--100.00%
app/Livewire/Registration
   CompanyBasicForm.php--100.00%
   CompanyLocationForm.php--100.00%
   CompanyRepresentativeForm.php--100.00%
   ParentComponent.php--100.00%
app/Mail
   BoothApprovedMailable.php--100.00%
   BoothDisapprovedMailable.php--100.00%
   CustomTeamInvitation.php--100.00%
   GenericNewUpdatesMailable.php--100.00%
   InviteCompany.php--100.00%
   InviteUser.php--100.00%
   PresentationApprovedMailable.php--100.00%
   PresentationDisapprovedMailable.php--100.00%
   SponsorshipApprovedMailable.php--100.00%
   SponsorshipDisapprovedMailable.php--100.00%
   TeamApprovedMailable.php--100.00%
   TeamDisapprovedMailable.php--100.00%
app/Models
   Booth.php--100.00%
   Company.php--100.00%
   Difficulty.php--100.00%
   Edition.php--100.00%
   EditionEvent.php--100.00%
   Event.php--100.00%
   FrequentQuestion.php100.00%100.00%100.00%
   Invitation.php--100.00%
   Presentation.php54.17%37.50%100.00%
   Room.php--100.00%
   Sponsorship.php--100.00%
   Timeslot.php--100.00%
   User.php89.13%87.50%100.00%
   UserPresentation.php--100.00%
app/Notifications
   NotifyBoothApproved.php--100.00%
   NotifyBoothDisapproved.php--100.00%
   NotifyPresentationApproved.php--100.00%
   NotifyPresentationDisapproved.php--100.00%
   NotifySponsorshipApproved.php--100.00%
   NotifySponsorshipDisapproved.php--100.00%
   NotifyTeamApproved.php--100.00%
   NotifyTeamDisapproved.php--100.00%
app/Observers
   BoothObserver.php--100.00%
   SpeakerObserver.php--100.00%
   TeamObserver.php--100.00%
app/Policies
   CompanyPolicy.php--100.00%
   PresentationPolicy.php--100.00%
   TeamPolicy.php--100.00%
   UserPolicy.php14.29%14.29%100.00%
app/Providers
   AppServiceProvider.php100.00%100.00%100.00%
   FortifyServiceProvider.php91.67%50.00%100.00%
   JetstreamServiceProvider.php100.00%100.00%100.00%
app/View/Components
   AppLayout.php100.00%100.00%100.00%
   ContentModBoothRequestDetails.php--100.00%
   ContentModCompanyRequestDetails.php--100.00%
   ContentModPresentationRequestDetails.php--100.00%
   ContentModSponsorRequestDetails.php--100.00%
   ContentModeratorBlock.php--100.00%
   ContentModeratorDashboard.php--100.00%
   EnrollModal.php--100.00%
   GoldSponsorSpeakerBlock.php--100.00%
   GuestLayout.php--100.00%
   HubLayout.php--100.00%
   HzTeamBlock.php--100.00%
   Map.php--100.00%
   PresentationDetails.php--100.00%
   ScheduleBlock.php--100.00%
   SidebarLink.php--100.00%
   SidebarLinkContentMod.php--100.00%
app/View/Components/Dashboards/Blocks
   Company.php--100.00%
app/View/Components/Dashboards
   Company.php--100.00%

:robot: comment via lucassabreu/comment-coverage-clover

IGORnvk commented 1 month ago

Still have to write some unit tests, but for now it can be opened for some manual testing and general review!

IGORnvk commented 1 week ago

All tests are failing - I'm especially more concerned about the build one. I tried running it locally and again failing with similar error.

image

With around 83 commits and multiple failing tests, rather than trying to fix everything in this PR, it might be better to create a new PR/branch to address these issues. What do you think, @TimKardol?

Yeah it is happening because of the Scheduler in console.php. It tries to retrieve current Edition when there is none, but I thought I fixed it already...

TimKardol commented 1 week ago

All tests are failing - I'm especially more concerned about the build one. I tried running it locally and again failing with similar error. image With around 83 commits and multiple failing tests, rather than trying to fix everything in this PR, it might be better to create a new PR/branch to address these issues. What do you think, @TimKardol?

Yeah it is happening because of the Scheduler in console.php. It tries to retrieve current Edition when there is none, but I thought I fixed it already...

I remember you fixing it haha