Closed IGORnvk closed 1 week ago
Coverage report for commit: c6bc98d
File: coverage.xml
Cover ┌─────────────────────────┐ Freq.
0% │ ███████████████████████ │ 85.4%
10% │ █░░░░░░░░░░░░░░░░░░░░░░ │ 1.5%
20% │ ░░░░░░░░░░░░░░░░░░░░░░░ │ 0.0%
30% │ ░░░░░░░░░░░░░░░░░░░░░░░ │ 0.0%
40% │ ░░░░░░░░░░░░░░░░░░░░░░░ │ 0.0%
50% │ █░░░░░░░░░░░░░░░░░░░░░░ │ 0.7%
60% │ ░░░░░░░░░░░░░░░░░░░░░░░ │ 0.0%
70% │ ░░░░░░░░░░░░░░░░░░░░░░░ │ 0.0%
80% │ █░░░░░░░░░░░░░░░░░░░░░░ │ 0.7%
90% │ █░░░░░░░░░░░░░░░░░░░░░░ │ 2.2%
100% │ ███░░░░░░░░░░░░░░░░░░░░ │ 9.5%
└─────────────────────────┘
*Legend:* █ = Current Distribution
:robot: comment via lucassabreu/comment-coverage-clover
Still have to write some unit tests, but for now it can be opened for some manual testing and general review!
All tests are failing - I'm especially more concerned about the build one. I tried running it locally and again failing with similar error.
With around 83 commits and multiple failing tests, rather than trying to fix everything in this PR, it might be better to create a new PR/branch to address these issues. What do you think, @TimKardol?
Yeah it is happening because of the Scheduler in console.php. It tries to retrieve current Edition when there is none, but I thought I fixed it already...
All tests are failing - I'm especially more concerned about the build one. I tried running it locally and again failing with similar error.
With around 83 commits and multiple failing tests, rather than trying to fix everything in this PR, it might be better to create a new PR/branch to address these issues. What do you think, @TimKardol?
Yeah it is happening because of the Scheduler in console.php. It tries to retrieve current Edition when there is none, but I thought I fixed it already...
I remember you fixing it haha
Description
Pull request introduces an edition management feature as well as the deadlines for the edition.
ERD for this particular part of the application:![image](https://github.com/HZ-HBO-ICT/it-conference/assets/71547534/63926362-1dd0-4868-a404-1a1ac73384ce)
editions
- previously called 'event_instance', represents edition (e.g. We are in IT together Conference 2024)events
- basically representing all the events that occur during the conference (e.g. Company registration, Presentation request etc.)edition_events
- table that connects events and edition during which these events are happening, and therefore it contains start and end dates for these events, since for every edition they can be different.Note 1: the icons for editions/events should be changed, since I just copied them from another part of the application.
Note 2: 99% that I forgot to add something somewhere, so feel free to correct me.
closes #410 and #325
Type of change
What needs to be tested
Checklist: