Closed IGORnvk closed 2 days ago
Coverage report for commit: 0f2e248
File: coverage.xml
Cover ┌─────────────────────────┐ Freq.
0% │ ███████████████████████ │ 74.4%
10% │ █░░░░░░░░░░░░░░░░░░░░░░ │ 1.7%
20% │ ░░░░░░░░░░░░░░░░░░░░░░░ │ 0.0%
30% │ █░░░░░░░░░░░░░░░░░░░░░░ │ 1.2%
40% │ █░░░░░░░░░░░░░░░░░░░░░░ │ 0.6%
50% │ █░░░░░░░░░░░░░░░░░░░░░░ │ 0.6%
60% │ ░░░░░░░░░░░░░░░░░░░░░░░ │ 0.0%
70% │ █░░░░░░░░░░░░░░░░░░░░░░ │ 1.2%
80% │ █░░░░░░░░░░░░░░░░░░░░░░ │ 1.7%
90% │ █░░░░░░░░░░░░░░░░░░░░░░ │ 2.9%
100% │ █████░░░░░░░░░░░░░░░░░░ │ 15.7%
└─────────────────────────┘
*Legend:* █ = Current Distribution
:robot: comment via lucassabreu/comment-coverage-clover
I'm a bit exhausted so I may overlook something. After the issues are fixed, I'll look at it more carefully. I have one question though:
I got it that the
Edition
date is the date of the conference and from what time till what time it's going to last. But considering the fact that theEvents
are part of theEdition
, shouldEdition
even have a date when it could be just anEvent
like 'Conference Day' or something like that? And if edition must have from/till wouldn't it make more sense to be from Kick-Off date to Retrospective day? I'm just asking not implying we should redo it, just discussing what would be optimal and make most sense.
For me it is not a problem to move start and end of the conference day to the separate event. I see these two implementations as almost the same, but from the logical perspective, having start and end of the edition attached to it makes more sense, than having a separate event for it. Just my opinion.
So if we change the logic and make the dates represent Kick-Off and Retrospective, what value would it bring? I don't remember that we had any features where we could use these dates. I would then rather just remove the dates from editions
and make them a separate event, but as I said, in my mind I can't see how this is better than the current version... Maybe @TimKardol can help us haha
I'm a bit exhausted so I may overlook something. After the issues are fixed, I'll look at it more carefully. I have one question though: I got it that the
Edition
date is the date of the conference and from what time till what time it's going to last. But considering the fact that theEvents
are part of theEdition
, shouldEdition
even have a date when it could be just anEvent
like 'Conference Day' or something like that? And if edition must have from/till wouldn't it make more sense to be from Kick-Off date to Retrospective day? I'm just asking not implying we should redo it, just discussing what would be optimal and make most sense.For me it is not a problem to move start and end of the conference day to the separate event. I see these two implementations as almost the same, but from the logical perspective, having start and end of the edition attached to it makes more sense, than having a separate event for it. Just my opinion.
So if we change the logic and make the dates represent Kick-Off and Retrospective, what value would it bring? I don't remember that we had any features where we could use these dates. I would then rather just remove the dates from
editions
and make them a separate event, but as I said, in my mind I can't see how this is better than the current version... Maybe @TimKardol can help us haha
Yeah no fair enough, makes sense. If @TimKardol doesn't give any input till let's say monday lunchtime and all issues are fixed I suggest we merge @IGORnvk?
I'm a bit exhausted so I may overlook something. After the issues are fixed, I'll look at it more carefully. I have one question though: I got it that the
Edition
date is the date of the conference and from what time till what time it's going to last. But considering the fact that theEvents
are part of theEdition
, shouldEdition
even have a date when it could be just anEvent
like 'Conference Day' or something like that? And if edition must have from/till wouldn't it make more sense to be from Kick-Off date to Retrospective day? I'm just asking not implying we should redo it, just discussing what would be optimal and make most sense.For me it is not a problem to move start and end of the conference day to the separate event. I see these two implementations as almost the same, but from the logical perspective, having start and end of the edition attached to it makes more sense, than having a separate event for it. Just my opinion. So if we change the logic and make the dates represent Kick-Off and Retrospective, what value would it bring? I don't remember that we had any features where we could use these dates. I would then rather just remove the dates from
editions
and make them a separate event, but as I said, in my mind I can't see how this is better than the current version... Maybe @TimKardol can help us hahaYeah no fair enough, makes sense. If @TimKardol doesn't give any input till let's say monday lunchtime and all issues are fixed I suggest we merge @IGORnvk?
Sure, I am now finishing the policy implementation and then it can be merged.
Description
Pull request introduces an edition management feature as well as the deadlines for the edition.
ERD for this particular part of the application:![image](https://github.com/HZ-HBO-ICT/it-conference/assets/71547534/63926362-1dd0-4868-a404-1a1ac73384ce)
editions
- previously called 'event_instance', represents edition (e.g. We are in IT together Conference 2024)events
- basically representing all the events that occur during the conference (e.g. Company registration, Presentation request etc.)edition_events
- table that connects events and edition during which these events are happening, and therefore it contains start and end dates for these events, since for every edition they can be different.Note 1: the icons for editions/events should be changed, since I just copied them from another part of the application.
Note 2: This pull request introduces only manual state changes, without automation based on dates (Laravel Scheduler), since there were issues with its implementation.
closes #410 and #325
Type of change
What needs to be tested
manage editions
button on theindex
page of the editions)Checklist: