HZ-HBO-ICT / it-conference

Official repository for the IT-Conference
https://weareinittogether.nl
MIT License
6 stars 0 forks source link

Revert "Revert "Feature - QR codes/ticket system"" #570

Closed TimKardol closed 2 weeks ago

TimKardol commented 3 weeks ago

Reverts HZ-HBO-ICT/it-conference#568

github-actions[bot] commented 3 weeks ago

Coverage report for commit: c4697a8 File: coverage.xml

Cover ┌─────────────────────────┐ Freq.
   0% │ ███████████████████████ │ 72.5%
  10% │ █░░░░░░░░░░░░░░░░░░░░░░ │  2.5%
  20% │ █░░░░░░░░░░░░░░░░░░░░░░ │  1.7%
  30% │ █░░░░░░░░░░░░░░░░░░░░░░ │  3.0%
  40% │ █░░░░░░░░░░░░░░░░░░░░░░ │  0.8%
  50% │ █░░░░░░░░░░░░░░░░░░░░░░ │  0.8%
  60% │ █░░░░░░░░░░░░░░░░░░░░░░ │  0.8%
  70% │ █░░░░░░░░░░░░░░░░░░░░░░ │  1.7%
  80% │ █░░░░░░░░░░░░░░░░░░░░░░ │  0.8%
  90% │ █░░░░░░░░░░░░░░░░░░░░░░ │  2.1%
 100% │ █████░░░░░░░░░░░░░░░░░░ │ 13.1%
      └─────────────────────────┘
 *Legend:* █ = Current Distribution 
Summary - Lines: 26.01% | Methods: 22.32%
FilesLinesMethodsBranches
app/Actions/Fortify
   CreateNewUser.php90.24%25.00%100.00%
   PasswordValidationRules.php100.00%100.00%100.00%
   ResetUserPassword.php100.00%100.00%100.00%
   UpdateUserPassword.php100.00%100.00%100.00%
   UpdateUserProfileInformation.php72.73%50.00%100.00%
app/Actions/Jetstream
   DeleteUser.php100.00%100.00%100.00%
app/Actions/Log
   ApprovalHandler.php95.83%50.00%100.00%
app/Actions/Permissions
   ReadPermissionConfig.php100.00%100.00%100.00%
app/Actions/Schedule
   PresentationAllocationHelper.php--100.00%
   PresentationConflictChecker.php--100.00%
   ResetSchedule.php--100.00%
app/Actions/Users
   AddParticipantToCompanyHandler.php--100.00%
app/Console/Commands
   AddParticipantToCompany.php--100.00%
   AddSpeakerToPresentation.php--100.00%
   AddToHz.php--100.00%
   ApproveLastCreatedCompany.php--100.00%
   ConfirmAllEmails.php--100.00%
   CreateAdmin.php7.69%33.33%100.00%
   CreateTicketsForVerifiedUsers.php--100.00%
   ModifyTimeslotDuration.php--100.00%
   SyncPermissions.php96.77%85.71%100.00%
   UpsertMasterData.php73.91%40.00%100.00%
app/Events
   FinalProgrammeReleased.php--100.00%
app/Http/Controllers
   CompanyController.php--100.00%
   Controller.php100.00%100.00%100.00%
   FrequentQuestionController.php--100.00%
   HomeController.php100.00%100.00%100.00%
   InvitationController.php--100.00%
   PresentationController.php--100.00%
   ProgrammeController.php--100.00%
   RegistrationController.php25.00%-100.00%
   SpeakerController.php--100.00%
app/Http/Controllers/Crew
   BoothController.php57.78%66.67%100.00%
   CompanyController.php96.74%75.00%100.00%
   CrewController.php--100.00%
   DefaultPresentationController.php100.00%100.00%100.00%
   EditionController.php--100.00%
   FeedbackController.php--100.00%
   FrequentQuestionController.php--100.00%
   PresentationController.php86.79%66.67%100.00%
   RoomController.php88.00%80.00%100.00%
   ScheduleController.php--100.00%
   SponsorshipController.php94.44%66.67%100.00%
   TicketController.php--100.00%
   UserController.php--100.00%
app/Http/Controllers/Hub
   CompanyController.php--100.00%
   ParticipantController.php--100.00%
app/Http/Livewire
   AuthNavigationMenu.php--100.00%
   DownloadPresentation.php--100.00%
   EmailNotificationPreference.php--100.00%
   GuestNavigationMenu.php--100.00%
   OverrideDifficulty.php--100.00%
   ReleaseFinalProgramme.php--100.00%
   RoomAndTimeslotSelector.php--100.00%
   ShowNotification.php--100.00%
app/Http/Livewire/Booths
   DeleteBoothForm.php--100.00%
   EditBoothModal.php--100.00%
app/Http/Livewire/Companies
   DeleteCompanyForm.php--100.00%
app/Http/Livewire/DefaultPresentations
   EditDefaultPresentationForm.php--100.00%
app/Http/Livewire/Presentations
   DeletePresentationForm.php--100.00%
   EditPresentationModal.php--100.00%
app/Http/Livewire/Rooms
   DeleteRoomForm.php--100.00%
app/Http/Livewire/Schedule
   AddTimeslotPadding.php--100.00%
   RemovePresentationFromSchedule.php--100.00%
   ReplacePresentation.php--100.00%
   ResetTimeslots.php--100.00%
app/Http/Livewire/Sponsorships
   CreateSponsorshipForm.php--100.00%
   DeleteSponsorshipForm.php--100.00%
app/Http/Livewire/Users
   DeleteUserForm.php--100.00%
app/Http/Middleware
   EditionMiddleware.php33.33%-100.00%
app/Http/Requests
   StorePresentationRequest.php100.00%100.00%100.00%
app/Jobs
   NotifyCompanyRoles.php63.64%50.00%100.00%
   NotifyPresentationRoles.php30.00%50.00%100.00%
app/Listeners
   EmailVerifiedListener.php--100.00%
   HandleFinalProgrammeReleased.php--100.00%
app/Livewire
   AuthNavigationMenu.php100.00%100.00%100.00%
   ConfirmationModal.php--100.00%
   EmailNotificationPreference.php--100.00%
   GuestNavigationMenu.php100.00%100.00%100.00%
   NotificationsList.php--100.00%
app/Livewire/Booth
   CreateBooth.php14.63%28.57%100.00%
   DeleteBoothModal.php--100.00%
   EditBoothModal.php--100.00%
   JoinBoothOwnerModal.php--100.00%
app/Livewire/Company
   AddMember.php--100.00%
   AddParticipant.php--100.00%
   BoothRequest.php--100.00%
   DeleteCompany.php--100.00%
   DeleteCompanyModal.php--100.00%
   DetailsForm.php--100.00%
   EditCompanyModal.php--100.00%
   ManageLogo.php--100.00%
   MemberManager.php--100.00%
   RemoveMember.php--100.00%
   SponsorshipRequest.php--100.00%
   UpdateMemberRole.php--100.00%
app/Livewire/Crew
   AddTeam.php--100.00%
   AssignRoleToUser.php--100.00%
   RevokeRoleOfUser.php--100.00%
   RolePermissionsInfo.php--100.00%
app/Livewire/Edition
   ActivateEditionModal.php--100.00%
   AddKeynoteModal.php--100.00%
   DeleteEditionModal.php--100.00%
   EditEditionModal.php--100.00%
app/Livewire/EditionEvent
   EditEditionEventModal.php--100.00%
app/Livewire/Forms
   BoothForm.php--100.00%
   CompanyForm.php--100.00%
   DefaultPresentationForm.php--100.00%
   EditionEventForm.php--100.00%
   EditionForm.php--100.00%
   FrequentQuestionForm.php--100.00%
   KeynoteForm.php--100.00%
   PresentationForm.php--100.00%
   RoomForm.php--100.00%
app/Livewire/FrequentQuestions
   DeleteFrequentQuestionModal.php--100.00%
   EditFrequentQuestionModal.php--100.00%
app/Livewire/Presentation
   DeletePresentationModal.php--100.00%
   EditPresentationModal.php--100.00%
   JoinAsSpeakerModal.php--100.00%
   UploadPresentation.php--100.00%
app/Livewire/QrCode
   InfoModal.php--100.00%
   Scanner.php--100.00%
   Ticket.php--100.00%
app/Livewire/Registration
   CompanyBasicForm.php8.33%25.00%100.00%
   CompanyInternshipsForm.php14.29%33.33%100.00%
   CompanyLocationForm.php10.00%33.33%100.00%
   CompanyMotivationForm.php16.67%33.33%100.00%
   CompanyRepresentativeForm.php7.69%33.33%100.00%
   ParentComponent.php2.44%25.00%100.00%
   SelectCountryCode.php25.00%28.57%100.00%
app/Livewire/Room
   DeleteRoomModal.php--100.00%
   EditRoomModal.php--100.00%
app/Livewire/Schedule
   AddDefaultPresentation.php--100.00%
   Cell.php--100.00%
   ConfirmResetScheduleModal.php--100.00%
   DefaultPresentation.php--100.00%
   EditDefaultPresentationModal.php--100.00%
   GridParentComponent.php--100.00%
   Presentation.php--100.00%
   PresentationModal.php--100.00%
   PublishProgrammeButton.php--100.00%
   PublishProgrammeModal.php--100.00%
app/Livewire/Sponsorship
   DeleteSponsorshipModal.php--100.00%
app/Livewire/Users
   UserFilteringList.php--100.00%
app/Mail
   BoothApprovedMailable.php100.00%100.00%100.00%
   BoothDisapprovedMailable.php--100.00%
   CancelledPresentationMailable.php--100.00%
   CompanyApprovedMailable.php100.00%100.00%100.00%
   CompanyDeletedMailable.php--100.00%
   CompanyDisapprovedMailable.php100.00%100.00%100.00%
   CompanyRepInvitation.php100.00%100.00%100.00%
   CompanyUpdatedMailable.php--100.00%
   CustomCompanyInvitation.php--100.00%
   FeedbackReceivedMailable.php--100.00%
   FinalProgrammeReleasedMailable.php--100.00%
   GenericNewUpdatesMailable.php--100.00%
Table truncated to fit comment

:robot: comment via lucassabreu/comment-coverage-clover

v-stamenova commented 3 weeks ago
image

Acceptance env. threw this when testing there - not sure if it's applicable for production env.

v-stamenova commented 3 weeks ago

image Acceptance env. threw this when testing there - not sure if it's applicable for production env.

If this issue occurs when Elio is hosting what needs to be done is to add to php config file (or create additional one) extension=imagick; might also need to add then "ext-imagick": "*" to the composer.json but I am not sure. If you change the composer.json don't forget to update the composer.lock :)

TimKardol commented 3 weeks ago

image Acceptance env. threw this when testing there - not sure if it's applicable for production env.

If this issue occurs when Elio is hosting what needs to be done is to add to php config file (or create additional one) extension=imagick; might also need to add then "ext-imagick": "*" to the composer.json but I am not sure. If you change the composer.json don't forget to update the composer.lock :)

When you add something to the composer file and then run composer install should it not automatically add it to the lock file? Or is it just to make sure that it actually populates it?

v-stamenova commented 3 weeks ago

image Acceptance env. threw this when testing there - not sure if it's applicable for production env.

If this issue occurs when Elio is hosting what needs to be done is to add to php config file (or create additional one) extension=imagick; might also need to add then "ext-imagick": "*" to the composer.json but I am not sure. If you change the composer.json don't forget to update the composer.lock :)

When you add something to the composer file and then run composer install should it not automatically add it to the lock file? Or is it just to make sure that it actually populates it?

I am not sure to be honest, but I believe it is depending on the way you add in to the composer file - if you manually add it to the composer.json then the lock file will become outdated and conflict will occur. But if you require the package, then it should automatically handle it.

TimKardol commented 2 weeks ago

I will merge as soon as the merge conflicts are gone

IGORnvk commented 2 weeks ago

I will merge as soon as the merge conflicts are gone

Fixed the conflicts, though did not test since I am at work, but it should be working as expected.