HZ-HBO-ICT / ts-skeleton-app

Little skeleton app for using TypeScript
MIT License
3 stars 22 forks source link

Compiled files in repository #2

Closed FrontEndCoffee closed 6 years ago

FrontEndCoffee commented 6 years ago

Usually it is not a good idea to have compiled files in your git-repository. There are files in the output folder.

I would suggest a few things:

If @Lucky-Loek is on board with this proposal I would be happy to draw up a PR!

Lucky-Loek commented 6 years ago

Completely agree, but this was on purpose. I want our freshman year students to see what the output is and how that changes when you change the source files. Maybe the name "skeleton app" wasn't the best idea :wink: I'd gladly accept output or dist folders though! Haven't really dabbled in JS up until now so those best practices are still unknown to me.

FrontEndCoffee commented 6 years ago

@Lucky-Loek I completely understand. I have one more thing though: you have chosen npm as package manager. This is of course great, as it is the default tool for managing node dependencies. However, yarn is a great alternative. Yarn was introduced by Facebook and Google as an alternative for the sloppy/slow/crappy npm client. It uses the same package repo (npmjs.com) but it is far superior. -> yarnpkg.com

I understand that you do not want to make it too complicated for the freshman year students, but I would really advise against using the default npm client.

Lucky-Loek commented 6 years ago

We only use NPM to install TypeScript, per the official docs. Is this the same procedure with Yarn? As in yarn add -g typescript? Cause I like Yarn a lot better too, but I see a couple of issues that Yarn and a global TS installation don't play well together.

FrontEndCoffee commented 6 years ago

I would use yarn, and avoid installing typescript globally all together (see https://github.com/HZ-HBO-ICT/ts-skeleton-app/issues/4)