search

HaDiNet / shiftings

Simple shift management system
MIT License
6 stars 3 forks source link

Add a calendar list view #26

Closed hd1ex closed 1 month ago

hd1ex commented 1 year ago

This change introduces list views. They are mostly a copy of the day views.

schliz commented 1 year ago

finally 🙏

vongaisberg commented 1 year ago

lgtm🕺

hd1ex commented 7 months ago

Has anyone had the time to review this? Is there something I can do to get this done soon?

Tjeri commented 6 months ago

Could you elaborate, what exactly this is supposed to do and solve. Maybe attach a screenshot to show? There is no explanation in here.

hd1ex commented 6 months ago

Could you elaborate, what exactly this is supposed to do and solve. Maybe attach a screenshot to show? There is no explanation in here.

The day (list) views are very useful to give someone an overview of all shifts applying to a filter. In the current version of shiftings, these views are limited to a day. So if I send someone a link to a day with a filter for an org applied, they can only see shifts of that org which start before 12pm on that day. The new list views allow the exact same functionality with the removed limitation of only showing shifts of a specific day. The existing filter view already has filters which can be used to set the exact time span, so these are reused.

In summary, the new introduced views here provide an easy way to show all shifts applying to a filter (e.g. of a given time span).

schliz commented 1 month ago

I have tested this again and everything seems to work. The left filter view in the calendar is still very messy but this is a problem for another time.

@Tjeri if you still have any input regarding this PR, I am happy to hear it.

@hd1ex thank you for your contribution, I'll go ahead and merge.