search

HaJaeKyung / KittyExtension

Fan add-on for https://www.cryptokitties.co
MIT License
232 stars 87 forks source link

Commonality values are hard-coded, should be dynamic #3

Open owap opened 6 years ago

owap commented 6 years ago

As the market adjusts to new cats being bred, the values in the tbl variable are going to change.

Consider populating the tbl variable on script startup by making an HTTP request to a service that gets the current rarity of traits. That way, every time the script is restarted, the commonality values are updated automatically without requiring a user to re-download scripts (or requiring you to publish updates!)

neuhaus commented 6 years ago

That and new traits (cattributes) are revealed quite often

HaJaeKyung commented 6 years ago

This is something I plan on adding. Just wanted to get it working in general first. I asked the KittyExplorer team if they would be able to provide the api for it.

elie222 commented 6 years ago

are hardcoded values at least accurate for now?

variousred commented 6 years ago

https://github.com/HaJaeKyung/KittyExtension/blob/master/script#L40 var tbl = {"violet":{"count":0},"googly":{"count":0.03},"wingtips":{"count":...

A little out of date eg googly has 81 (0.071%) kitites (at the time of this post)

arcane47 commented 6 years ago

Already done in at: https://github.com/mammothb/KittyExtension/commit/856bf0e1248a37e28165327a662306f8992adc63