HaarigerHarald / omxiv

OpenMax image viewer for the Raspberry Pi
GNU General Public License v2.0
222 stars 66 forks source link

Error while running make on Linux 5.4.65-1-ARCH #33

Closed isThatHim closed 3 years ago

isThatHim commented 4 years ago

Hello, i cloned the git repo, ran make ilclient successfully, and then tried to run make.

Sadly the command fails with

sudo make -j4 cc -o omxiv.bin omxiv.o omx_image.o omx_render.o soft_image.o ./libnsbmp/libnsbmp.o ./libnsgif/libnsgif.o -lilclient -ljpeg -lpng -lrt -ldl -Wl,--gc-sections -s -L/opt/vc/lib/ -lopenmaxil -lbcm_host -lvcos -lpthread -L./libs/ilclient /usr/bin/ld: omx_render.o:/home/alarm/omxiv/omx_render.h:71: multiple definition of `OMX_RENDER_TRANSITION'; omxiv.o:/home/alarm/omxiv/omx_render.h:71: first defined here collect2: error: ld returned 1 exit status make: *** [Makefile:13: omxiv.bin] Error 1

I am running

Linux pi 5.4.65-1-ARCH #1 SMP PREEMPT Tue Sep 15 16:21:17 UTC 2020 armv7l GNU/Linux

and i previously installed raspberrypi/userland to runmake ilclient successfully.

I also installed libjpeg and libpng from the Arch-Repos. I updated and restarted my system.

Does someone know what i did wrong?

Thanks in advance!

HaarigerHarald commented 4 years ago

I'd guess someone introduced an OMX_RENDER_TRANSITION in one of the openmaxil libs. Can you try to rename the OMX_RENDER_TRANSITION in omx_render.h to something else and do a:

make clean all
isThatHim commented 4 years ago

Hello, i could solve the issue by adding "typedef" infront of the struct OMX_RENDER_TRANSITION in omx_render.h.

Everything compiled flawlessly now.

Ruffio commented 4 years ago

@isThatHim how about a PR?