search

HabchiSarra / SmellDetector

GNU Affero General Public License v3.0
3 stars 1 forks source link

[orWall] Some analyzed commits are absent from smell files #8

Open aveuiller opened 7 years ago

aveuiller commented 7 years ago

When smells are processed in https://github.com/aveuiller/MetricsCalculator for the project orWall, we only have an output of 582 commits out of 595 analyzed ones. We can see that those commits does not appear in the output SMELL files (even NOSMELL).

To be more precise, the missing commit numbers are:

  1. 161: https://github.com/EthACKdotOrg/orWall/commit/2c5b31de8e0c497e5697354c0425681c68e59362
  2. 162: https://github.com/EthACKdotOrg/orWall/commit/d16b022bab3aebdf55941fc76fc80db338c4745e
  3. 163: https://github.com/EthACKdotOrg/orWall/commit/83e91c394e4619fd6a4a524e3659356c6a874550
  4. 165: https://github.com/EthACKdotOrg/orWall/commit/8edd2a55017192cebc4001bd8ba6adfc2e9547d4
  5. 166: https://github.com/EthACKdotOrg/orWall/commit/b702dff8c4689b36484d83c4ea00a9ead51275b2
  6. 167: https://github.com/EthACKdotOrg/orWall/commit/6b3e086922d866ee6ec4404141668cd232f01850
  7. 178: https://github.com/EthACKdotOrg/orWall/commit/f2b5b52aad34e21e3ae105efc69b6aa945ed674e
  8. 183: https://github.com/EthACKdotOrg/orWall/commit/258ec30cf799cb91b73d303384f9daf410e4b52d
  9. 184: https://github.com/EthACKdotOrg/orWall/commit/056645ae76e5ed134ab22e7e5e1b99f7f29c3ef4
  10. 260: https://github.com/EthACKdotOrg/orWall/commit/de8db56562ff81308d9cd4e54f165be2abc89680
  11. 310: https://github.com/EthACKdotOrg/orWall/commit/1248fde597b87a2bb3c8f17cb88665ebaac7b195
  12. 454: https://github.com/EthACKdotOrg/orWall/commit/15232219a13e66e995d0f5fe5f9866f72171179c
  13. 455: https://github.com/EthACKdotOrg/orWall/commit/b5b5a926c16aacbad6e68c91dbca0e4f1dd1b196
aveuiller commented 7 years ago

The project has been processed two times to eliminate any case of database corruption

aveuiller commented 7 years ago

After verification, those specifics commits seems to be absent from the database.

e.g. (commit 161): 

I, [2017-07-20T17:50:58.960381 #39537]  INFO -- : App: orWall, commit 2c5b31de8e0c497e5697354c0425681c68e59362, DONE WITH EXCEPTION(S) RAISED BY PAPRIKA
D, [2017-07-20T17:50:58.960562 #39537] DEBUG -- : err: spoon.SpoonException: Printing of spoon.support.reflect.code.CtFieldReadImpl on path 
        CtPackageImpl:org
        CtPackageImpl:ethack
        CtPackageImpl:orwall
        CtClassImpl:PreferencesActivity
        CtClassImpl:NetworkPrefs
        CtFieldImpl:listener
        CtNewClassImpl
        CtClassImpl:1
        CtMethodImpl:onSharedPreferenceChanged
        CtBlockImpl
        CtIfImpl
        CtBlockImpl
        CtInvocationImpl
        CtFieldReadImpl:PARAM_ACTIVATE
at position (/home/sarra/orWall/app/src/main/java/org/ethack/orwall/PreferencesActivity.java:126) failed
        at spoon.reflect.visitor.DefaultJavaPrettyPrinter.scan(DefaultJavaPrettyPrinter.java:307)
        at spoon.reflect.visitor.DefaultJavaPrettyPrinter.visitCtInvocation(DefaultJavaPrettyPrinter.java:1162)
        at spoon.support.reflect.code.CtInvocationImpl.accept(CtInvocationImpl.java:57)
        at spoon.reflect.visitor.DefaultJavaPrettyPrinter.scan(DefaultJavaPrettyPrinter.java:298)
        at spoon.reflect.visitor.printer.ElementPrinterHelper.writeStatement(ElementPrinterHelper.java:139)
        at spoon.reflect.visitor.DefaultJavaPrettyPrinter.visitCtBlock(DefaultJavaPrettyPrinter.java:476)
        at spoon.support.reflect.code.CtBlockImpl.accept(CtBlockImpl.java:49)
        at spoon.reflect.visitor.DefaultJavaPrettyPrinter.scan(DefaultJavaPrettyPrinter.java:298)
        at spoon.reflect.visitor.printer.ElementPrinterHelper.writeStatement(ElementPrinterHelper.java:139)
        at spoon.reflect.visitor.printer.ElementPrinterHelper.writeIfOrLoopBlock(ElementPrinterHelper.java:366)
        at spoon.reflect.visitor.DefaultJavaPrettyPrinter.visitCtIf(DefaultJavaPrettyPrinter.java:1076)
        at spoon.support.reflect.code.CtIfImpl.accept(CtIfImpl.java:46)
        at spoon.reflect.visitor.DefaultJavaPrettyPrinter.scan(DefaultJavaPrettyPrinter.java:298)
        at spoon.reflect.visitor.printer.ElementPrinterHelper.writeStatement(ElementPrinterHelper.java:139)
        at spoon.reflect.visitor.DefaultJavaPrettyPrinter.visitCtBlock(DefaultJavaPrettyPrinter.java:476)
        at spoon.support.reflect.code.CtBlockImpl.accept(CtBlockImpl.java:49)
        at spoon.reflect.visitor.DefaultJavaPrettyPrinter.scan(DefaultJavaPrettyPrinter.java:298)
        at spoon.support.reflect.declaration.CtElementImpl.toString(CtElementImpl.java:249)
        at analyzer.ExecutableProcessor.countEffectiveCodeLines(ExecutableProcessor.java:57)
        at analyzer.ExecutableProcessor.process(ExecutableProcessor.java:38)
        at analyzer.ClassProcessor.processMethods(ClassProcessor.java:63)
        at analyzer.ClassProcessor.process(ClassProcessor.java:50)
        at analyzer.ClassProcessor.process(ClassProcessor.java:23)
        at spoon.support.visitor.ProcessingVisitor.scan(ProcessingVisitor.java:92)
        at spoon.reflect.visitor.CtScanner.visitCtNewClass(CtScanner.java:581)
        at spoon.support.reflect.code.CtNewClassImpl.accept(CtNewClassImpl.java:35)
        at spoon.reflect.visitor.CtScanner.scan(CtScanner.java:150)
        at spoon.support.visitor.ProcessingVisitor.scan(ProcessingVisitor.java:88)
        at spoon.reflect.visitor.CtScanner.visitCtField(CtScanner.java:387)
        at spoon.support.reflect.declaration.CtFieldImpl.accept(CtFieldImpl.java:68)
        at spoon.reflect.visitor.CtScanner.scan(CtScanner.java:150)
        at spoon.support.visitor.ProcessingVisitor.scan(ProcessingVisitor.java:88)
        at spoon.support.visitor.ProcessingVisitor.scan(ProcessingVisitor.java:64)
        at spoon.reflect.visitor.CtScanner.visitCtClass(CtScanner.java:308)
        at spoon.support.reflect.declaration.CtClassImpl.accept(CtClassImpl.java:69)
        at spoon.reflect.visitor.CtScanner.scan(CtScanner.java:150)
        at spoon.support.visitor.ProcessingVisitor.scan(ProcessingVisitor.java:88)
        at spoon.support.visitor.ProcessingVisitor.scan(ProcessingVisitor.java:64)
        at spoon.reflect.visitor.CtScanner.visitCtClass(CtScanner.java:308)
        at spoon.support.reflect.declaration.CtClassImpl.accept(CtClassImpl.java:69)
        at spoon.reflect.visitor.CtScanner.scan(CtScanner.java:150)
        at spoon.support.visitor.ProcessingVisitor.scan(ProcessingVisitor.java:88)
        at spoon.support.visitor.ProcessingVisitor.scan(ProcessingVisitor.java:64)
        at spoon.reflect.visitor.CtScanner.visitCtPackage(CtScanner.java:629)
        at spoon.support.reflect.declaration.CtPackageImpl.accept(CtPackageImpl.java:57)
        at spoon.reflect.visitor.CtScanner.scan(CtScanner.java:150)
        at spoon.support.visitor.ProcessingVisitor.scan(ProcessingVisitor.java:88)
        at spoon.support.visitor.ProcessingVisitor.scan(ProcessingVisitor.java:64)
        at spoon.reflect.visitor.CtScanner.visitCtPackage(CtScanner.java:628)
        at spoon.support.reflect.declaration.CtPackageImpl.accept(CtPackageImpl.java:57)
        at spoon.reflect.visitor.CtScanner.scan(CtScanner.java:150)
        at spoon.support.visitor.ProcessingVisitor.scan(ProcessingVisitor.java:88)
        at spoon.support.visitor.ProcessingVisitor.scan(ProcessingVisitor.java:64)
        at spoon.reflect.visitor.CtScanner.visitCtPackage(CtScanner.java:628)
        at spoon.support.reflect.declaration.CtPackageImpl.accept(CtPackageImpl.java:57)
        at spoon.reflect.visitor.CtScanner.scan(CtScanner.java:150)
        at spoon.support.visitor.ProcessingVisitor.scan(ProcessingVisitor.java:88)
        at spoon.support.QueueProcessingManager.process(QueueProcessingManager.java:119)
        at spoon.support.QueueProcessingManager.process(QueueProcessingManager.java:131)
        at spoon.support.compiler.jdt.JDTBasedSpoonCompiler.process(JDTBasedSpoonCompiler.java:184)
        at spoon.Launcher.process(Launcher.java:707)
        at analyzer.MainProcessor.process(MainProcessor.java:57)
        at analyzer.Main.runAnalysis(Main.java:105)
        at analyzer.Main.main(Main.java:50)
Caused by: java.lang.NullPointerException
        at spoon.reflect.visitor.DefaultJavaPrettyPrinter.printCtFieldAccess(DefaultJavaPrettyPrinter.java:775)
        at spoon.reflect.visitor.DefaultJavaPrettyPrinter.visitCtFieldRead(DefaultJavaPrettyPrinter.java:747)
        at spoon.support.reflect.code.CtFieldReadImpl.accept(CtFieldReadImpl.java:27)
        at spoon.reflect.visitor.DefaultJavaPrettyPrinter.scan(DefaultJavaPrettyPrinter.java:298)
        ... 68 more