[Enhancement] Disable upcoming reminder if task is alredy done

HabitRPG / habitica-android

Native Android app for Habitica

GNU General Public License v3.0

1.46k stars 520 forks source link

[Enhancement] Disable upcoming reminder if task is alredy done #1972

Closed pwall2222 closed 3 months ago

pwall2222 commented 1 year ago

When you create a task and create this reminders:

In 30 min
In 1 hour
In 2 hour And you after 1 hour check off the task, the 2 hours reminder will still pop up even though the task is finished. (From what I have searched through the code, it's a matter of when completing a task in completeTaskForUser, to delete or disable the reminders)

phillipthelen commented 1 year ago

The app checks if a task was completed before displaying the notification. Did you complete your task in the app or on the website? Otherwise that check might not be working correctly in your case.

pwall2222 commented 1 year ago

I'm checking it on my device, and I go look and the task is checked off alredy too but I still get the notification.

saraolson commented 1 year ago

haven't been able to reproduce on 4.2

saraolson commented 1 year ago

had a report of this from a user in regards to To Do reminders, which may be why we couldn't reproduce. we were testing daily reminders previously. will test this more thoroughly in the coming days and report back.

saraolson commented 3 months ago

We made some updates to the reminder system that may have improved this. When testing, i didn't receive the reminder for a ToDo i completed, and did receive one for the ToDo that hadn't been completed yet.

Gonna close this optimistically :D