search

HabitRPG / habitica-android

Native Android app for Habitica
GNU General Public License v3.0
1.45k stars 514 forks source link

Delete task confirmation button should always been Maroon100 #2042

Closed saraolson closed 5 months ago

saraolson commented 11 months ago

Right now the delete task button that shows in the confirmation modal is themed to the task color. Since it's confirming a destructive action, we should make it always show as Maroon100. The 'cancel' option can stay themed.

arjun1194 commented 11 months ago

can i pick this up ?? its my first time contributing to Habitica. @saraolson

arjun1194 commented 11 months ago

Also i saw that destructive buttons are themed to be with a "Red" background. are you sure you want it to be "Maroon_100" ?

saraolson commented 8 months ago

@arjun1194 Hi there, very sorry for the delay! Holidays made this slip through the cracks. If you're still interested, you're welcome to take this on. And yes, Maroon 100 is darker than red, so white text can be read more easily. We would want destructive buttons to be Maroon 100

arjun1194 commented 8 months ago

Hey, thanks for your response. I am interested to pick this up

Just to confirm, All the destructive buttons should be maroon100 right ?

arjun1194 commented 8 months ago

https://github.com/HabitRPG/habitica-android/pull/2063

saraolson commented 7 months ago

Thanks for taking the time to make a PR for this! Our developer will review it and release with the next version update.