search

HabitRPG / habitica-android

Native Android app for Habitica
GNU General Public License v3.0
1.41k stars 508 forks source link

Fixes #1861: Make the entire like layout clickable vs just the text #2052

Closed jsoberg closed 8 months ago

jsoberg commented 8 months ago

Previously just the text itself was clickable here, so I made the parent layout clickable instead. Ideally this layout would be a bit larger for a11y reasons, Google recommends 48dp minimum touch target size (link) but I left the sizing as-is for now.

my Habitica User-ID: caef89d8-3a3d-4d3b-a5ad-67cb0455a56e

Hafizzle commented 8 months ago

Hey @jsoberg, thanks a bunch for this tweak!

Really smart move to make the entire layout clickable – it's little changes like these that can make a big difference, especially for accessibility.

As for the touch target size - good call! I think keeping Google's guidelines in mind is super important. We might play around with the sizing down the line, but for now, what you've done is spot on. TY!

jsoberg commented 8 months ago

Thanks @Hafizzle! I love the app btw, I'm hoping to contribute more regularly as time permits!