search

HabitRPG / habitica-android

Native Android app for Habitica
GNU General Public License v3.0
1.41k stars 508 forks source link

Fixes #2043 - Make sure that filter icon isn't shown in rewards tab #2053

Closed jsoberg closed 7 months ago

jsoberg commented 8 months ago

I noticed here that at present we're intentionally trying to hide the filter menu item from the Rewards tab on the tasks screen.

The only time the filter icon is being shown is the first time that you open the Rewards tab, due to the fact that activeFragment will always be null when coming from the onPageSelected callback (since it hasn't had time to inflate and be set yet). This PR moved the getTaskTypeFromTabPosition that we can call from the few places it was being duplicated in this Fragment, and makes sure to use the position directly when available so that we don't have to check the activeFragment when it could be null.

my Habitica User-ID: caef89d8-3a3d-4d3b-a5ad-67cb0455a56e

saraolson commented 7 months ago

@jsoberg thanks so much for your contribution! I've added record of it to your Habitica profile and granted your 2nd contributor tier 🎉 we'll be releasing it in the 4.3.4 update.