search

HabitRPG / habitica-android

Native Android app for Habitica
GNU General Public License v3.0
1.41k stars 508 forks source link

switching to landscape mode after opening the armoire for free shows the wrong item #2065

Closed rilygreat closed 1 month ago

rilygreat commented 6 months ago

how to reproduce on version 4.3.5:

  1. open armoire
  2. switch to landscape mode to check if the visual bug happens
  3. go back to portrait mode, open armoire again with the free sub perk option
  4. switch to landscape mode
  5. item shown isn’t the one that was purchased on step 2, but instead the item from step 1
  6. switch back to portrait

https://github.com/HabitRPG/habitica-android/assets/102926641/d7b84229-36cc-47b6-a32b-fbf59bb836b3

jsoberg commented 4 months ago

Testing this out and just wanted to point out the biggest issues I'm seeing, along with @rilygreat's video:

  1. The layout isn't scrollable in landscape, so if you open this in landscape you don't even see the option to equip/close/open again
  2. You can keep rotating and opening again for free perpetually - each time you rotate, you get the option to open again for free and get a new item
EanLombardo commented 1 month ago

It looks like this was fixed in 415c6348f788067f09171deb88f05f452398ba4b

saraolson commented 1 month ago

Yup! The correct item shows now. Theres still some improvements we want to make to the screen after rotating, but the item part of this is fixed.