search

HabitRPG / habitica-chat-extension

A habitica.com Chat Client for Chrome
18 stars 13 forks source link

Minified code preventing publication on Firefox Add-ons #40

Closed paglias closed 5 years ago

paglias commented 5 years ago

We got an email from the Firefox Add-ons website (https://addons.mozilla.org/it/firefox/) letting us know that the extension can't be published as long as it contains minified code

This version contains obfuscated, minified, concatenated or otherwise machine-generated code. Please provide the original sources, together with instructions on how to generate the final XPI. Source code must be provided as an archive and uploaded using the source code upload field, which can be done during submission or on the version page in the developer hub

I think the issue comes from the presence of minified jquery code here, here and the markdown code here.

It'll have to be moved to separate files (jquery) and unminified before it can be published

cc @cTheDragons

crookedneighbor commented 5 years ago

Alternatively, jquery can just be removed as a dependency. :)

crookedneighbor commented 5 years ago

I think I’ll have a bit of free time tonight or tomorrow. Will give it a go if I have the chance.

cTheDragons commented 5 years ago

Hi @crookedneighbor Any luck?

crookedneighbor commented 5 years ago

Yeah, it’s in progress.

crookedneighbor commented 5 years ago

Turns out there’s a ton of jquery in these files :dizzy:

crookedneighbor commented 5 years ago

Got it started here: https://github.com/crookedneighbor/habitica-chat-extension/tree/remove_jquery

crookedneighbor commented 5 years ago

Not gonna have a chance to keep working on it for a while, so if y'all want to go that route, feel free to use the branch and go from there.

TBH, if you want a quick fix, just use the un-minified versions of the scripts.

cTheDragons commented 5 years ago

I'm thinking we should use that. As that all I would do.

@paglias Did you have any thoughts?

paglias commented 5 years ago

I'm fine with just using the unminified version !

Il Ven 3 Mag 2019, 11:02 cTheDragons notifications@github.com ha scritto:

I'm thinking we should use that. As that all I would do.

@paglias https://github.com/paglias Did you have any thoughts?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/HabitRPG/habitica-chat-extension/issues/40#issuecomment-489019696, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEQAV6VJY67NBMSTCGVJY3PTP5TDANCNFSM4HJGKHOQ .

cTheDragons commented 5 years ago

@crookedneighbor are you ok to create the Pull Request or would you like me to do it?

Do we need to do any formal testing with it?

paglias commented 5 years ago

@cTheDragons I'd say if it loads and works normally for us we're good to go without extensive testing

godless-toast commented 5 years ago

What's the status? I know there's work being done to make the developer's lives easier with #42, but it's been almost 2 months and I'd love to be able to use the extension on Firefox.

benjaminbhollon commented 5 years ago

I think we're trying to work out bugs in Browserify right now.

paglias commented 5 years ago

Published again, let's see how it goes

paglias commented 5 years ago

It's been approved 🎉 thanks @benjaminbhollon !

Alys commented 5 years ago

For the benefit of anyone following this issue, it looks like its been moved to a new URL: https://addons.mozilla.org/en-US/firefox/addon/habitica-chat-client-2/ (or possibly the link in the wiki page had been wrong).

I've updated the wiki page (https://habitica.fandom.com/wiki/Chat_Extension).