search

HabitRPG / habitica-chat-extension

A habitica.com Chat Client for Chrome
19 stars 13 forks source link

Purify fix #58

Closed CraigInches closed 4 years ago

CraigInches commented 4 years ago

The DOMPurify santiization was applied widely, but it actually removed functions to make the client work. I modified to sanitize the variables, but static html is left untouched.

Fixes #55

paglias commented 4 years ago

Thanks @CraigInches , I'll upload a new version to the stores as soon as the other PRs get merged. If you have an Habitica username I'll be happy to award a contribution tier for the PR!

CraigInches commented 4 years ago

@paglias I am Morat on Habitica :) glad to help

edit by Alys 2020-06-06: Just noting for the record here: User ID 8b819da9-81e7-42e4-992e-cd1a9c3a823b in case we need to refer back in future if the Username changes. :)

paglias commented 4 years ago

thanks @CraigInches ! Noted towards your 2nd tier