search

HabitRPG / habitica-chat-extension

A habitica.com Chat Client for Chrome
18 stars 13 forks source link

Fix noon and midnight times for 12 hour clock, issue #57 #59

Closed junewerner closed 4 years ago

junewerner commented 4 years ago

When set to a 12 hour time midnight was displayed as 0:00 am and noon was displayed as 12:00 am. I fixed the time parsing logic, now mid night is displayed as 12:00 am and noon is displayed as 12:00 pm. This resolves issues #57.

Alys commented 4 years ago

I've added a comment related to this PR in the issue: https://github.com/HabitRPG/habitica-chat-extension/issues/57#issuecomment-634998645 I thought it would be better added there rather than here so that we can keep the discussion of the preferred fix in one place.

@junewerner I'm sorry I didn't post there earlier!

junewerner commented 4 years ago

Alright, this should now be fixed up to now display "12:01 am" at midnight and "noon" at noon.

paglias commented 4 years ago

Thanks @junewerner for this and the other PR! I'll be happy to award a contribution tier on Habitica if you want, just send your username or uuid

junewerner commented 4 years ago

Sounds great! My uuid is 2c5b537e-7c0c-4ae8-834e-6caac46b6834