HabitRPG / habitica-chrome

Chrome extension for HabitRPG. Uses 3rd party productivity website events to trigger point gain/loss.
https://chrome.google.com/webstore/detail/habitrpg/pidkmpibnnnhneohdgjclfdjpijggmjj?hl=en-US
GNU General Public License v3.0
109 stars 47 forks source link

Over-awarding when "" (empty) host in good hosts #150

Closed brazilianldsjaguar closed 8 years ago

brazilianldsjaguar commented 8 years ago

By putting a blank host ("") in good hosts, I can incorrectly gain on non-listed sites (in neither list). This is due to the new loop that ultimately gets the host down to "" through shift().

brazilianldsjaguar commented 8 years ago

I fixed this in PR 149:

https://github.com/HabitRPG/habitrpg-chrome/pull/149