HabitRPG / habitica-ios

Native iOS app for Habitica
GNU General Public License v3.0
712 stars 235 forks source link

Stuck progress notification when buying a reward with no internet connection #1293

Closed drincon1 closed 4 months ago

drincon1 commented 1 year ago

Describe the bug The bug is presented when trying to buy a new reward in the 'Rewards' section and the user has enough coins to buy the reward without internet connection. When there is no internet connection and the buy button is pressed, a stuck progress indicator appears. Even when the connection is recuperated, the progress indicator keeps on spinning until the user taps the button again.

To Reproduce Steps to reproduce the behavior are:

  1. Without any internet connection, enter to the Rewards tab.
  2. Select any element available that costs less than the coin you have.
  3. Press the 'Buy' button.
  4. Connect to the internet. Result: The progress spinner will continue.

Expected behavior The progress indicator should not appear when there is no internet connection.

Screenshots IMG_09C9E20424A9-1

Smartphone (please complete the following information):

saraolson commented 4 months ago

We've vastly improved server response time that should make it so this isn't encountered through normal use of the app much at all. Closing this issue, though if we receive player reports we can re-evaluate.