HabitRPG / habitica-ios

Native iOS app for Habitica
GNU General Public License v3.0
711 stars 234 forks source link

Collection quest drops aren't showing when you complete tasks #1310

Open saraolson opened 1 year ago

saraolson commented 1 year ago

you should get a toast that tells you when you get a pending item for your collection quest, but that toast doesn't show for me. i just have to go to my party and see if i have any pending items after i complete my tasks

tjb commented 7 months ago

investigating this i see we are doing a toast for found items in TaskRepositoryImpl#126

            if let drop = response.temp?.drop {
                var dialog = drop.dialog
                if dialog == nil {
                    dialog = "You found a \(drop.key ?? "")"
                }
                ToastManager.show(text: dialog ?? "", color: .gray)
            }

the response looks has a shape of TaskResponseTempProtocol but the quest prop only has a progressDelta.

@phillipthelen is there somewhere else in the code that sends a signal when a pending item is found? Or would require an update to the backend to include this information and then modify TaskResponseQuestProtocol?