Fix notes section on rewards does not expand and gets cut off

HabitRPG / habitica-ios

Native iOS app for Habitica

GNU General Public License v3.0

711 stars 234 forks source link

Fix notes section on rewards does not expand and gets cut off #1312

Closed giovannapezzini closed 1 year ago

giovannapezzini commented 1 year ago

Closes #1301

my Habitica User-ID: 76ec69ee-f02d-4b55-b622-c0d8e381d155

Hello 👋 happy to make my first contribution to the project.

Changes:

Replaces sizeForItemAt and insetForSectionAt collection view methods for a UICollectionViewCompositionalLayout
Set number of lines of CustomRewardCell to zero so it's expandable

Note: When rotating the iPhone I notice this bug in production, this is also fixed in this pull request

Demo

Multiple Lines

iPhone 8	iPhone 14

iPad Mini	iPad Pro

giovannapezzini commented 1 year ago

This Pull Request is ready for review! I'm used to leave comments to give a bit of context, please let me know you have any other questions or inquiries 🙂 Have a good weekend!

saraolson commented 1 year ago

@giovannapezzini thanks so much for your contribution! we'll review it in a test build and let you know if we need any changes. if everything looks good, we'll grant you contributor credit for your habitica profile :)

saraolson commented 1 year ago

@giovannapezzini Everything looks good! this PR will be released in the next iOS update, 3.8. I've added this contribution to your habitica profile and granted you a contributor tier 🎉