search

HabitRPG / habitica-ios

Native iOS app for Habitica
GNU General Public License v3.0
712 stars 235 forks source link

#1316: Show mount pixel art on bottom sheet #1320

Closed tjb closed 1 year ago

tjb commented 1 year ago

my Habitica User-ID: e8160fe6-2e6d-494f-b7db-60befa34fe8a

The source of the issue was - vs. _. I noticed that with pets the urls use - but with mounts we use _. I would recommend speaking with the backend team and have these urls be consistent

Examples:

Pet --> https://habitica-assets.s3.amazonaws.com/mobileApp/images/stable_Pet-Wolf-Veteran.png

Mounts: Does not work --> https://habitica-assets.s3.amazonaws.com/mobileApp/images/stable_Mount-Icon-Gryphon-RoyalPurple.png

Does work with this PR --> https://habitica-assets.s3.amazonaws.com/mobileApp/images/stable_Mount_Icon_Gryphon-RoyalPurple.png

tjb commented 1 year ago

cc: @phillipthelen

saraolson commented 11 months ago

@tjb This PR is merged + tested and will be released along with some other updates to the pets & mounts bottom sheet in iOS 3.9. I've upped your contributor tier to 3 as well 🎊 thanks for your help!