HabitRPG / habitica-zapier

6 stars 5 forks source link

Push to Zapier on git tag #12

Closed Majed6 closed 4 years ago

Majed6 commented 4 years ago

Continuous delivery for habitica-zapier . Can be triggered from Github UI by simply creating a release.

After merging this you need to set ZAPIER_DEPLOY_KEY in the Project Secrets with value of deployKey in your local .zapierrc. i.e if .zapierrc content is

{
  "deployKey": "xyz"
}

the value of the secret is xyz. Adding a secret is documented here

paglias commented 4 years ago

I think this is good to go as well, but I will wait for @Alys ' question to be answered before

Alys commented 4 years ago

I've added ZAPIER_DEPLOY_KEY.

@Majed6 Thanks very much for the clear instructions and the link to the docs!

Alys commented 4 years ago

Initial discussion was here: https://github.com/HabitRPG/habitica-zapier/pull/8#issuecomment-596197264 (just linking to it in case we want to refer back to it later)

Alys commented 4 years ago

I've added this as credit towards tier 3. Thank you!

Alys commented 4 years ago

I tried using this after merging the refactoring PR but it's failed. It could well be because I didn't do it right. :)

I created a release with tag v3.0.0: https://github.com/HabitRPG/habitica-zapier/releases/tag/v3.0.0 The push failed: https://github.com/HabitRPG/habitica-zapier/runs/508942771

v3.0.0
npm ERR! code 128
npm ERR! Command failed: git tag v3.0.0 -m 3.0.0
npm ERR! fatal: tag 'v3.0.0' already exists
npm ERR! 
Majed6 commented 4 years ago

Just tried it without v and went to the next step. Cloud you please try creating a release without v ? v3.0.0 should be 3.0.0

Sorry for that.

Majed6 commented 4 years ago

Try release 3.0.1

Alys commented 4 years ago

No worries, and that worked!! Awesome, thanks. :)

Majed6 commented 4 years ago

Yippee! Happy to hear that.

paglias commented 4 years ago

I wanted to comment on this earlier but if we use npm version patch|minor|major we'll get both an updated package.json and a new git tag created automatically