search

HabitRPG / habitica

A habit tracker app which treats your goals like a Role Playing Game.
https://habitica.com
Other
11.79k stars 4.05k forks source link

Update achievements to work with notification object #11257

Open phillipthelen opened 5 years ago

phillipthelen commented 5 years ago

The way achievements are displayed on web is often done by comparing the fields directly. Instead the server should update the notifictations property on the user to add information about the gained notification. Same way it is already done for the Ultimate Gear achievements or Back to basics. This is essential for the achievements to work properly across the mobile apps and the website.

List of achievements that need to be updated:

I marked this as Help Wanted in case a contributor wants to work on one or multiple of these before I have time.

Xaz16 commented 5 years ago

Hello @phillipthelen! Is it still Help wanted issue? As I can see we already have PR for that

paglias commented 5 years ago

@Xaz16 I'll remove the label as this is being handled by @phillipthelen

Xaz16 commented 5 years ago

@paglias thank you :)

beffymaroo commented 2 years ago

@SabreCat Should this one get a Help Wanted tag again?

SabreCat commented 2 years ago

oh gosh, absolutely. Not touched since 2019!

CuriousMagpie commented 2 years ago

I'll take this one, too, since I'm also handling #11541 and they're related.