Client Auth: refactor components

HabitRPG / habitica

A habit tracker app which treats your goals like a Role Playing Game.

https://habitica.com

Other

12.05k stars 4.1k forks source link

Client Auth: refactor components #11482

Open paglias opened 5 years ago

paglias commented 5 years ago

We have three different components that more or less do the same thing: signup and signin.

They're located in

website/client/src/components/auth/registerLoginReset.vue
website/client/src/components/auth/authForm.vue
website/client/src/components/static/home.vue

They share most design and almost all the business logic and should be combined into a single one where possible.

It would also make sense to abstract the auth verification logic (used when choosing or changign your username)

ShupingHe commented 4 years ago

can i take this one ? : )

huaw commented 4 years ago

I just started to watch your community. Is there good one I can contribute to?

On Sun, Dec 8, 2019, 8:45 AM 动力小车 notifications@github.com wrote:

can i take this one ? : )

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/HabitRPG/habitica/issues/11482?email_source=notifications&email_token=AAQBYLBRY7IK5FU4XACQHRTQXT26FA5CNFSM4JFSLIC2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGG67EQ#issuecomment-562950034, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAQBYLARJTMUWLM3M2CBMBDQXT26FANCNFSM4JFSLICQ .

Alys commented 4 years ago

@Stevens1995 Thanks! Please go ahead and post here if you have questions.

@huaw Hi! First off, have a look at the Guidance for Blacksmiths wiki page if you haven't already seen it, and the pages it links to. They'll give you a lot of useful information about contributing. The "good first issue" GitHub label might have some simple issues, or you can look at any of the "help wanted" ones. If you have questions, drop in to the Aspiring Blacksmiths (Coding For Habitica) guild. :)

ShupingHe commented 4 years ago

@Alys is it OK to change some text and style when refactor the component? I guess the answer is not, but if it's allowed, it would be much easier to abstrat the component

for example, in the home page, the register button show sign up: and it's different in the group-plans page:

Alys commented 4 years ago

My feeling is that it would be good to have consistency across the forms, if only for ease of coding and translating but it's not something I can make a decision on. :)

FYI @Tressley