Allocating 100 stat points to one stat causes text to overflow from the box

HabitRPG / habitica

A habit tracker app which treats your goals like a Role Playing Game.

https://habitica.com

Other

11.94k stars 4.07k forks source link

Allocating 100 stat points to one stat causes text to overflow from the box #11738

Closed shanaqui closed 4 years ago

shanaqui commented 4 years ago

Not so much a bug as it is a formatting issue, but I just noticed when I reached level 100 (woo!) and put my 100th stat point into intelligence, that the "pts" text after the number 100 gets pushed out of the box and moved underneath it. I assume this is because the number has become three digits and the entire "100 pts" text doesn't fit in the box.

Reported by JohnJSal in Report a Bug.

Alys commented 4 years ago

I'm labelling this as "neds design" in case @Tressley wants to comment but if there's no objection in a week, I'll change it to help wanted for expanding the Stat Points boxes slightly to accommodate three-digit numbers and slightly longer "pts" labels that might exist in other languages.

wScottSh commented 4 years ago

If no one objects, I can tackle this one.

I'm going through the contributing docs right now. I'll post if I have any questions.

Alys commented 4 years ago

@wScottSh Thank you! Please go ahead!

Tressley commented 4 years ago

@wScottSh -- Thanks for taking this on! Here are some quick changes:

Update the label from "pts" to "points"
The boxes should be wide enough to have 24px of space between them. As you can see in Shanaqui's screenshot above, the Strength container isn't flush to the left margin of "Stat Points" heading.

wScottSh commented 4 years ago

Sure thing.

wScottSh commented 4 years ago

I've made it through the docs, but haven't yet set up my environment. I'll have time this weekend to do so. Just keeping you in the loop.

shanaqui commented 4 years ago

@wScottSh Hi! Are you still interested in working on this one? Please let us know if so!

wScottSh commented 4 years ago

@shanaqui Thanks for checking in, I apologize for not closing this loop earlier.

No, now is not the time for me to take this on. Family has been in the hospital and I haven't had the cycles dedicated to getting the environment working properly. Feel free to open it back up.

shanaqui commented 4 years ago

Thanks for updating! I'll mark it as help wanted.

inftp commented 4 years ago

Hi there, Can I try this one?

Alys commented 4 years ago

@inftp Sure, thank you! Post here if you have questions or run into trouble.