search

HabitRPG / habitica

A habit tracker app which treats your goals like a Role Playing Game.
https://habitica.com
Other
11.99k stars 4.09k forks source link

HTML page Title tag for Guilds says "Group Plans" #12738

Closed Alys closed 3 years ago

Alys commented 4 years ago

When you are viewing a Guild that does not have a Group Plan, the title says "Group Plans". It should say "Guilds".

The two examples below are public guilds that definitely don't have Group Plans in them.

image image

Thanks to @citrusella for reporting this.

Alys commented 4 years ago

@thewilloftheshadow / beinginhisshadow (2eb203f5-1b1e-4e5d-84a4-22f130a1090e) has posted technical details:

"... the Group Plans does show up for me. I went looking in the code, and saw that the section is in fact set to the wrong variable for line 504 in this file:

https://github.com/HabitRPG/habitica/blob/d678eb920f9b2c581475f1be4b9d1581ca64fa57/website/client/src/components/groups/group.vue#L500-L508

this.$store.dispatch('common:setTitle', {section: this.$t('groupPlans'), subSection: this.group.name });

"This was changed in PR https://github.com/HabitRPG/habitica/pull/12627 which was pulled to the server today"

thewilloftheshadow commented 4 years ago

I can take this on (:

Alys commented 4 years ago

@thewilloftheshadow Fantastic, thanks. :) It's yours.

thewilloftheshadow commented 4 years ago

Sorry about the delay, I'm having trouble setting up my local copy so I can test and make sure the change didn't affect anything else

paglias commented 4 years ago

Looks like normal guilds / parties and group plans use the same component (group.vue) so we'll have to add a check on whether you're viewing the group as a group plan or not (probably by looking at whether group-plans is in the url). Note that with https://github.com/HabitRPG/habitica/pull/12743 merged there are a couple more places to update in the component file, make sure to work on an up to date version of the develop branch.

@thewilloftheshadow let me know if you need any help

thewilloftheshadow commented 4 years ago

I think I got it all, but there is one space to check that I noted in the PR