HabitRPG / habitica

A habit tracker app which treats your goals like a Role Playing Game.
https://habitica.com
Other
11.5k stars 4k forks source link

No positive integration tests #15230

Open DanielLipowicz opened 3 weeks ago

DanielLipowicz commented 3 weeks ago

I review the API repository and I see that there is no positive integration testing at all. Because I've not found anything I decide to play a little with JS and I wrote additional scenario.

  it('returns an success when message and email is added', async () => {
    await expect(user.post('/bug-report', {
      message: 'Something is wrong here',
      email: user.auth.local.email,
    }))
      .to.eventually.to.contain({
        code: 200,
      });
  });

Before I spend more time on this I would like to ensure that this strategy is welcome in Habitica. IMO covering this gap would provide more confidence to each changed done in scope of API and Clients.

Please let me know if you would like to see my contribution in tests here. If you assign this ticket to me I will cover some endpoints and create PR with improved test coverage.

DanielLipowicz commented 3 weeks ago

PR added https://github.com/HabitRPG/habitica/pull/15232