search

HabitRPG / habitica

A habit tracker app which treats your goals like a Role Playing Game.
https://habitica.com
Other
11.83k stars 4.05k forks source link

Custom Day Start Reset #1929

Closed lemoness closed 10 years ago

lemoness commented 10 years ago

Just checked, and my custom day start was reset to zero. Lots of complaints in the tavern, too - this is going to cause a lot of deaths if it isn't fixed soon.

ghost commented 10 years ago

Yes, mine was as well. I was changing my end of day from 2 to 3 (it was just after midnight when I was doing this) and the page reset to zero. Not sure if my fussing with the time contributed.

Esstheruth commented 10 years ago

My custom day start had been 3 a.m. for two weeks already, and my day reverted back to midnight after I clicked on one of my dailies around 12:45 a.m. Lost HP and had to reset several daily streaks.

JesperDramsch commented 10 years ago

Mine was at 7 am and reset in the middle of the night. When I set it back to 7 this night, the dailies did not reset at said time.

veeeeeee commented 10 years ago

Clicked a couple things after midnight; page reloaded with clean dailies and a daily start time reset to midnight. Also nearly died as a result, which was, erm, interesting.

FireNRice commented 10 years ago

Logged in to check off some dailies and was already dead. My custom day start was set at 4AM, and it got reverted to midnight. Lost armor, over 1300 gold and experience points.

etryn commented 10 years ago

Happened to me too. Fortunately I didn't die-- sorry to those of you who did! Hopefully you can restore!

Mousekiro commented 10 years ago

Hit me last night, too. I didn't die, but I went to check off one of my kitchen-cleaning dailies before bed only to find all my dailies unchecked and some of them had lost their streak. When I figured out what had happened, I changed the day start back to 6:00, but I was still quite wary, so I stuck myself in the Inn. Which is a good thing, because when I logged on this morning, it was back to 0:00 again. Seems every time I reload the site, it has decided anew that I want to reset at midnight.

Blauelf commented 10 years ago

As mousekiro said, custom day start seems to reset on every reload/sync. Language preference, which also got reset from English back to my browser's default, does not.

Eiron commented 10 years ago

This has also affected me. But with my other issues due to heavy load restoring the streaks is a bit of an arduous task, as I get frequent browser locks. I am often busy until after midnight, so I need those extra hours for last-minute checking before I do finally get to bed.

paglias commented 10 years ago

@lefnire I think that https://github.com/HabitRPG/habitrpg/commit/2b128f71f45b2b3cb873eacbe36f8212f28a1dad is preventing any value other than 0 from being used.

You can set values client-side as long as you don't try to delete the old value, because it will set it to 0, you can only replace it with a number by selecting the old value. And server-side is always resetted to 0.

wisteriacs commented 10 years ago
paglias commented 10 years ago

Sorry about this guys, it's now fixed (not live on the site yet!) but for every one who logged in in the last hours the custom day start has been resetted to 0, we may restore old values from a backup but let's wait for @lefnire

lefnire commented 10 years ago

@paglias fixed this, I've deployed fix to both production & beta. I've also ran a migration to restore 0'd dayStarts for users who haven't manually updated after the bug. Everything should be good now, thanks @paglias, and sorry everyone.

Some background on what happened. There were a lot of users whose dayStarts wasn't a whole number (eg 2), but they were entering 2:00, which caused Mongoose cast errors, and their accounts couldn't load. I added some validation yesterday to change the dayStart to 0 if it wasn't a proper number, but there was a bug in the validation (which @paglias fixed)

paglias commented 10 years ago

@lefnire could be that a cause for all that mess with custom day start not working? The fact that validation prevents deleting the hour (in order to change it) and that it's saved at every change (for example when using the increase/decrease button) is quite annoying

lefnire commented 10 years ago

You mean could the other dayStart issues be connected to invalid dayStart (ie, before this push)? I don't think so, to be honest.. I think their accounts wouldn't even load at all when they had invalid dayStarts. I got some emails, people saying "I get red errors and no tasks", and this was the cause

paglias commented 10 years ago

it would have been too easy :(

lefnire commented 10 years ago

I know :( I thought about it too, a brief glimmer of hope and then "oh... no..."