HabitRPG / habitica

A habit tracker app which treats your goals like a Role Playing Game.
https://habitica.com
Other
12k stars 4.09k forks source link

Critical hits need their own alert callout #2029

Closed SabreCat closed 10 years ago

SabreCat commented 10 years ago

For a little while after the Classes rollout, I was baffled at why sometimes I was getting upwards of 6 gold for a single click, and other times I got only 2 or so. My hunch at this point (after the recent PER rebalancing) is that critical hits are happening sometimes? Do we display an alert "Critical hit!" or similar to let the user know what just happened?

Some cool animations would be awesome, but at least we need an alert, heh.

lefnire commented 10 years ago

yep

On Tue, Dec 17, 2013 at 6:39 PM, Sabe Jones notifications@github.comwrote:

For a little while after the Classes rollout, I was baffled at why sometimes I was getting upwards of 6 gold for a single click, and other times I got only 2 or so. My hunch at this point (after the recent PER rebalancing) is that critical hits are happening sometimes? Do we display an alert "Critical hit!" or similar to let the user know what just happened?

Some cool animations would be awesome, but at least we need an alert, heh.

— Reply to this email directly or view it on GitHubhttps://github.com/HabitRPG/habitrpg/issues/2029 .

SabreCat commented 10 years ago

Er... "yep" we have an alert already, or "yep" we need one?

lefnire commented 10 years ago

yep we definitely need one. was on my workflowy, but better in GH - thanks!

On Tue, Dec 17, 2013 at 6:53 PM, Sabe Jones notifications@github.comwrote:

Er... "yep" we have an alert already, or "yep" we need one?

— Reply to this email directly or view it on GitHubhttps://github.com/HabitRPG/habitrpg/issues/2029#issuecomment-30809819 .