Gem-Less Tavern Challenges

deilann commented 10 years ago

I don't believe you've waived the gem requirement for tavern challenges? However, I've seen some as of late.

We've got "sleep better hours," "cycle monitoring with sensi-plan," "learn 250 SAT words," and "Weight Watchers Team" currently.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

wc8 commented 10 years ago

I believe there’s a gem requirement, but not a prize requirement—I could be mistaken though. Regardless, are you referring to prizes or actually being able to start a challenge without paying gems?

lefnire commented 10 years ago

the prize is the same amount of gems they put into creating the challenge, so if we're seeing 0-gem tavern chals, there is indeed a problem. Will look into later

hattieshoe commented 10 years ago

I noticed this too -- there's now another one, "Smile more," with no gems -- and I wondered how they're doing it, so I tried all kinds of things to create a challenge for the tavern with no gems (not selecting a prize amount, setting it to zero, setting it higher but changing it to zero, entering a negative number, selecting a guild and then changing it to the tavern, etc.) but couldn't get it to happen. May not be helpful, but I thought there could possibly be a clue in there somewhere so thought I'd mention it.

deilann commented 10 years ago

Yeah, I can't figure it out either. Cannot reproduce, but it's certainly happening.

deilann commented 10 years ago

Two more have shown up since I last checked. "walk you dog" and... something else.

deilann commented 10 years ago

Another one: "max out"

deilann commented 10 years ago

Okay, user Black Sheep2 has created two more. Are there any third party ways to create challenges? Could it be that's what bypassing this?

wc8 commented 10 years ago

API? https://habitrpg.com/static/api#!/challenges

deilann commented 10 years ago

Yeah, but I'm wondering if there are any specific third-party programs/extensions/integrations that allow creation of challenges.

On Wed, Jan 29, 2014 at 3:04 PM, wc8 notifications@github.com wrote:

API.

Reply to this email directly or view it on GitHubhttps://github.com/HabitRPG/habitrpg/issues/2380#issuecomment-33642201 .

deilann commented 10 years ago

lightsaber sez:

@!("Ryan") Oh… I didn't knew! I just entered a zero into the gem-field. That's all. I've got firefox 16.0.2 and ad-blocker on a mac.

paglias commented 10 years ago

In theory the api has a check for public challenges that should prevent this https://github.com/HabitRPG/habitrpg/blob/develop/src/controllers/challenges.js#L137 but probably it's not working

deilann commented 10 years ago

Lightsaber seems to be saying that the challenge wasn't created 3rd party -- just by putting "zero" in the field in Firefox.

On Sat, Mar 29, 2014 at 8:05 AM, Matteo Pagliazzi notifications@github.comwrote:

In theory the api has a check for public challenges that should prevent this https://github.com/HabitRPG/habitrpg/blob/develop/src/controllers/challenges.js#L137but probably it's not working

Reply to this email directly or view it on GitHubhttps://github.com/HabitRPG/habitrpg/issues/2380#issuecomment-38998086 .

deilann commented 10 years ago

I'm just wondering what's special about when lightsaber did it and why it doesn't work for everyone.

On Sat, Mar 29, 2014 at 3:00 PM, Ryan yandoryn@gmail.com wrote:

Lightsaber seems to be saying that the challenge wasn't created 3rd party -- just by putting "zero" in the field in Firefox.

On Sat, Mar 29, 2014 at 8:05 AM, Matteo Pagliazzi < notifications@github.com> wrote:

In theory the api has a check for public challenges that should prevent this https://github.com/HabitRPG/habitrpg/blob/develop/src/controllers/challenges.js#L137but probably it's not working

Reply to this email directly or view it on GitHubhttps://github.com/HabitRPG/habitrpg/issues/2380#issuecomment-38998086 .

paglias commented 10 years ago

Yes but internally the same api method should be used Il 29/mar/2014 23:01 "deilann" notifications@github.com ha scritto:

Lightsaber seems to be saying that the challenge wasn't created 3rd party -- just by putting "zero" in the field in Firefox.

On Sat, Mar 29, 2014 at 8:05 AM, Matteo Pagliazzi notifications@github.comwrote:

In theory the api has a check for public challenges that should prevent this

https://github.com/HabitRPG/habitrpg/blob/develop/src/controllers/challenges.js#L137butprobably it's not working

Reply to this email directly or view it on GitHub< https://github.com/HabitRPG/habitrpg/issues/2380#issuecomment-38998086> .

Reply to this email directly or view it on GitHubhttps://github.com/HabitRPG/habitrpg/issues/2380#issuecomment-39010497 .

deilann commented 10 years ago

Ah, true. idek. Maybe it has something to do with the adblocker?

lemoness commented 10 years ago

Is this still an issue that's happening?

paglias commented 10 years ago

Still happening, I just created one with 0 gems prize

Alys commented 10 years ago

If you select "Tavern" AFTER you have entered 0 for the gems, the gem amount test does not occur. If you select "Tavern" BEFORE you enter the gem amount, it does occur. Tested on my local install only.

TheHollidayInn commented 9 years ago

I was working on another ticket and found this issue. I create a pull request which does the gem check during the $watch and on save phase. Does my pull request fix this issue as well: https://github.com/HabitRPG/habitrpg/pull/4836 ?

deilann commented 9 years ago

We're now getting a lot of challenges with no title. This is also still happening.

Challenges with no gems:

Personally, I think all of them should be deleted. Users can choose to keep the tasks if they desire.

crookedneighbor commented 9 years ago

@deilann What do you mean there is no title? Each one I clicked on did have a title. I must be misunderstanding something.

deilann commented 9 years ago

All of those are challenges with no gem prize, not challenges with no title. I cannot link to challenges with no title because there is no title to click on to generate a link.

crookedneighbor commented 9 years ago

Ahh, I see, you were listing two separate things.

Alys commented 9 years ago

Ignore my previous (now deleted comment). @deilann and I are chatting about ways of getting more info for those listed challenges for working out how best to deal with them.

I will clean up ones with no title through the database.

deilann commented 9 years ago

@crookedneighbor I was not very clear, but by the time I was done listing all of them, I was too exhausted to look back and see if my sentences even made logical.

On Mon, Jun 8, 2015 at 4:08 PM, Alys notifications@github.com wrote:

@deilann https://github.com/deilann I can clean up ones with no title through the database. I'll go through those others that you've listed and either remove them or discuss with Lemoness. Thank you very not much for the list. :)

— Reply to this email directly or view it on GitHub https://github.com/HabitRPG/habitrpg/issues/2380#issuecomment-110167972.

crookedneighbor commented 9 years ago

List of challenges with no name:

Alys commented 9 years ago

@crookedneighbor I can identify those in the database easily with a search on title and I'll clean them up there as I find them.

crookedneighbor commented 9 years ago

Yep, that's what I did. Just posting for posterity. (And in case another mod wants to see)

beffymaroo commented 9 years ago

I found this thread very entertaining. Thank you all for your hard work, especially @deilann ;)

Alys commented 9 years ago

The challenges with no name/title have been deleted except for one that was a challenge in a party with one person. I have given it a name (the challenge ID) so that it doesn't come up in future searches. The owner hasn't logged in for a while, so I won't bother telling them, unless anyone asks me to. Challenge ID c567a712-a39b-4765-a280-b7ceae2b9a8e

The deleted challenges all either:

had no tasks, or
had pointless tasks AND few/no participants AND were months old (usually many months)

Alys commented 9 years ago

From the Tavern challenges that have no gems, I have deleted the ones below (I saved a copy of each). They were either more than a year old OR had no tasks.

I'll go through the others later, when I'm not using this as an excuse to procrastinate on things that are more urgent. :-/

2cc62c7f-126c-486e-a392-70b601263982 364d902d-b843-4d40-ac67-381fd30d5525 4537fe91-0293-4b3b-873f-211349aea0e8 483cfe1c-9b3c-4c53-aa7c-84bcbe042d42 592b21b9-cdfb-43d6-a96b-b64afdfe3bd2 74dd400d-c51e-4d25-8d54-f85fdf092bf4 99065ef5-4fef-46f5-b87c-0e657ef35a7b ad6925ec-482f-443d-8d9d-52946d3e9761 b0ea4010-6aad-4726-aa45-87e70354de19

Alys commented 9 years ago

I've deleted more gem-less Tavern challenges (saved a copy of each). They were either rather pointless or very old.

d88a8386-261f-48e9-bef0-5222f2cbd0e8 e9a119b6-7cc0-46f1-bf86-9b1b125728b4 b4965a66-adda-4cdf-a906-f9e405edc200 77e187e5-d7f8-4d3d-b720-ecc2175ee9be 3f4868cf-bd63-49e8-8f44-1161b1a5eec1 d5911161-8081-4d13-9934-a4d252c1fad6 b9719168-a3d9-4149-9ad8-4e73b8f18e37 fa73b48d-d967-4ae4-a2b7-0a4df11771ac c391677a-35c6-473b-b15a-81bc8ed55031 ea7f818a-4b9a-4384-baa3-07e5795d77d7 d8b1462e-ce34-48df-addc-7280d34d6c14 de886093-ff2b-496c-bd84-b5cf5df81eaa cef2c77f-d279-405b-bce5-99c79bc5ed3c 6cd394f7-68f8-4597-b58b-11fb3d158585 eb47a846-920b-4d2c-99ba-484b58591968 e4850c22-0b3c-4258-8992-dfd15843a332 726dd737-20e0-4084-99fc-2700af004740 791e02a8-f1a6-4087-a41e-9e833af6980f 795d14b1-224d-44c3-be3c-1912aceda3a4 dc390a98-a580-4ca3-8c17-6bea2df96bb1 90ad5982-b8b6-4e98-aef2-d153d3199983 d294a695-6694-481a-b956-cf0c86c21b88 a4c09e74-ae02-4baa-9880-ab3a0527f6b6 b98e050b-ad7a-4fa1-9023-4c0821346aed

There's still 21 gem-less Tavern challenges, but they all seem to have some value and some are only a month old. I'll go through them in more detail later.

db.challenges.find({ 'prize':0, 'group':'habitrpg' }, {
    'id':1, 'name':1, 'prize':1, 'timestamp':1,
    'memberCount':1, 'group':1, 'leader':1, 'description':1,
    'habits.text':1, 'dailys.text':1, 'todos.text':1, 'rewards.text':1,
} ,{multi:true}).pretty()

Alys commented 8 years ago

There are no more gem-less Tavern challenges.

HabitRPG / habitica

Gem-Less Tavern Challenges #2380