search

HabitRPG / habitica

A habit tracker app which treats your goals like a Role Playing Game.
https://habitica.com
Other
11.99k stars 4.09k forks source link

dragging tasks sometimes results in just selecting text #324

Closed mattrozak closed 11 years ago

mattrozak commented 11 years ago

since the new push today, sometimes when I try to drag a task up or down I just end up selecting the text and surrounding area. sceenshot below...

Chrome 24.0.1312.57 on OSX 10.8 Screen Shot 2013-02-06 at 11 54 25 PM

mattrozak commented 11 years ago

I should note that the cursor is on the task (it's a four-way arrow) and is not in between two tasks when i initially click.

horusofoz commented 11 years ago

@lefnire Confirmed. This has also been annoying me all day. Suspect since the last code push.

Chrome Win7

Pandoro commented 11 years ago

Confirmed on ubuntue 10.04, FF17 as well

On Thu, Feb 7, 2013 at 9:55 AM, horusofoz notifications@github.com wrote:

@lefnire https://github.com/lefnire Confirmed. This has also been annoying me all day. Suspect since the last code push.

Chrome Win7

— Reply to this email directly or view it on GitHubhttps://github.com/lefnire/habitrpg/issues/324#issuecomment-13226944.

StanLindsey commented 11 years ago

Confirmed, but i think it seems to happen when the page isn't fully loaded. Try refreshing the page if you have this issue.

rikikiangel commented 11 years ago

My habits suddenly got rearranged today by itself and I tried to rearrange it which I can't(not sometimes, cannot at all), refreshing doesn't work, forgot to say the page is fully loaded. Using Opera 12.12, Windows XP

DesignLemming commented 11 years ago

Had this problem this morning but a refresh seemed to fix it and I was able to reorder things. Checked back in this afternoon and the order was back to the pre-fixed one but again unable to drag and drop. Tried a refresh and was able to move one thing right away but then couldn't drag any more. Refreshed a few time any was able to fix everything but after logging out and back in everything reverted back the the old order.

On win XP, Chrome.

killroy42 commented 11 years ago

Currently cannot move anything, even after refreshing.

lefnire commented 11 years ago

Sort is broken for everyone, hang tight guys - I'm diagnosing it, but #330 is higher priority to me ATM

mfcovington commented 11 years ago

May or may not be a coincidence, but when sort broke for me:

  1. I was adding a new reward (which was successfully added)
  2. I noticed two new armor rewards (Buckler and Chain Coif) for the first time ever

_Edit (11pm Pacific 2/9):_ Sort is now almost working for me. I'm able to sort Habits, Dailies, and Rewards; however, sorting Todos results in seemingly random placement.

lefnire commented 11 years ago

New armor is a recent feature add, a potential fix to dailies is in master#head now and will be pushed soon - I'll check back

mfcovington commented 11 years ago

Sorting is currently back to normal for me.

horusofoz commented 11 years ago

Still an issue for myself. Chrome WinXP/7

kwilson328 commented 11 years ago

Experiencing this issue on Chrome, OS X 10.7.5 Seems to be triggered when I try to drag just far enough that it would require a small amount of scrolling. Minor sorts (like swapping two that are adjacent) works fine after a refresh

ianjohnsa commented 11 years ago

I also am experiencing this issue on Chrome and Win 7. Shows the four-way arrow moving cursor indicator thingy but just selects text when I try to drag.

wildcate commented 11 years ago

Same for me (Win7, Firefox).

MiriamELewis commented 11 years ago

Still happening, its getting very frustrating now. Can't move anything at all, it just selects text. Also can't use the +/- buttons.

wildcate commented 11 years ago

Same here - only selecting text (though the + - buttons work for me). The one time the re-ordering was possible everything was back to the old order after a refresh.

Olathe commented 11 years ago

Some reports are also in issue #501. It seems to occur more (though not by much) repeatably if I hold down the mouse button and move even a pixel or two even if no text is selected. Refreshing sometimes helps but, again, not always.

cmackley commented 11 years ago

I can't reorder tasks at all anymore. I would see this problem now and then but I'd refresh and it'd go away. In Chrome, it stopped working altogether so I moved to running Habit in firefox. Now firefox isn't working. This is definitely going to push me away from the product as reordering is key to organizing my todos.

The only workaround I can find is that there's a brief (1-2 second) period where I can drag and drop. If I hit refresh, let the page mostly* load, DnD works but as soon as one of the last server request comes back it stops working. I tried getting more specific details on which server request it is but the calls are too similar and not very descriptive.

On Win7 w/ Chrome, Firefox, IE9 and Win8 w/ IE10

EDIT: I just bought a shield (lvl 2 shield, buckler I think) and reorder started working (win7, firefox). I opened it in a new tab and it still doesn't work there. So I won't be refreshing my browser anytime soon. :)

kwilson328 commented 11 years ago

I've tried the best I can to break it, but this issue seems completely resolved for me. Can anyone else confirm? I've yet to get the "text selection" error, and every refresh I do saves my re-ordering. This is great!

OS X 10.7 Chrome 25.0.1364.99

cmackley commented 11 years ago

I have a consistent repro!

I'm still unable to sort with my lvl 4 character. Yet if I log out and use the default, playground character that you get by hitting Start on the splash screen, I can sort there. However, as soon as I add a task with (, ), $, or : I can no longer sort.

Here's the repro:

  1. Sign out if you're already signed in.
  2. Navigate to https://habitrpg.com/splash.html
  3. Try to drag tasks around. Note they do drag and drop.
  4. Add a new Todo: "characters like $ ( ) : will me!"
  5. Try to drag the task to reorder. Expected: Drag and drop still works. Actual: Text is selected.

Sounds like there's an issue parsing or scrubbing the user inputs. I'd even guess that it's on the server side as I don't see any errors in the browser's debug console, but JS doesn't always throw errors :).

kwilson328 commented 11 years ago

Now, several hours later, the issue is back in full force. Guess I jumped the gun in celebrating.

Pandoro commented 11 years ago

@kwilson328 can you confirm or refute that you have any special characters like $ or ( or ) in your tasks?

kwilson328 commented 11 years ago

In a few random todos I have the following % , ' ? + - I have a couple habits with ! and /

lefnire commented 11 years ago

yeah, i can't replicate with special characters either.

wildcate commented 11 years ago

I cannot sort either; I have ( and ) and : and ! and " in my tasks as well as ä, ö and ü. Sorting sort of never functioned properly for me; there was a day or two when I could move one thing for a bit and then it fell of the cursor and just sat somewhere. I also cannot sort the rewards.

lefnire commented 11 years ago

note to self, going to try to move all public/vendor js files back into <Scripts:> as page re-renders don't re-establish the require() statements from loadJavascripts

lefnire commented 11 years ago

can y'all try logging into your same accounts on our staging server and see if this problem exists there? (possible fix above). Remember this site gets wiped periodically, so don't get too cozy there.

michalmau commented 11 years ago

It works OK on staging!

Pandoro commented 11 years ago

Works for me as well. See #577 for different problems though :x

On Mon, Mar 4, 2013 at 6:12 PM, Michal Mau notifications@github.com wrote:

It works OK on staging!

— Reply to this email directly or view it on GitHubhttps://github.com/lefnire/habitrpg/issues/324#issuecomment-14392173 .

lefnire commented 11 years ago

deployed, re-open if still an issue